appium-boneyard / sign

Sign.jar automatically signs an apk with the Android test certificate.
406 stars 119 forks source link

[QN] When to Sign? #11

Closed pundoo closed 6 years ago

pundoo commented 6 years ago

When should I sign my apk using this signer? Before or after zipAlign-ing?

KazuCocoa commented 6 years ago

Basically nothing.

Google has released apksigner and we call it as a primary signing method. https://github.com/appium/appium-adb/blob/9fa581d84e1e5aebf44112e5ad05f64ddbb3be8e/lib/helpers.js

But https://github.com/appium/appium-adb/blob/70b1f91242dc9c5fbe30dda769eb01f0b9b09bbe/lib/tools/apk-signing.js#L172 may help to understand the order.