search

appium / WebDriverAgent

A WebDriver server for iOS and tvOS
Other
1.19k stars 371 forks source link

feat: Support prebuiltWDAPath for iOS 17 #868

Closed KazuCocoa closed 6 months ago

KazuCocoa commented 6 months ago

closes https://github.com/appium/appium/issues/19206#issuecomment-2014182674

This method requires WDA package that DOES NOT have Frameworks/XC** in the WDA package. The configuration is the same as what users can get via https://github.com/appium/WebDriverAgent/releases

With the XC***, the WDA app launches successfully but the app ends immediately because testmanagerd process fails to start. Potentially we can avoid this limitation when our appium-ios-device gets the new protocol, or 3rd party tools. (I haven't tested)

Tested with:

I'll update https://appium.github.io/appium-xcuitest-driver/latest/guides/run-preinstalled-wda/ page as well later.

KazuCocoa commented 6 months ago

updated

github-actions[bot] commented 6 months ago

:tada: This PR is included in version 7.3.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

yehe01 commented 4 months ago

This approach doesn't seem to work for simulators. iOS 17.0 Xcode 15.0

The wda crashes upon launch:

Screenshot 2024-06-05 at 12 15 25 AM
KazuCocoa commented 4 months ago

This change is mostly for real devices. For simulators, it might work with an app built on the same machine. I haven't dug into details for simulators.

yehe01 commented 4 months ago

“it might work with an app built on the same machine”

I was building the app on my local machine and removing the XC* files in the runner app. I thought the function works for both sims and real devices because the doc says so:/ any plan to add support in the near future?

On Wed, 5 Jun 2024 at 1:43 AM, Kazuaki Matsuo @.***> wrote:

This change is mostly for real devices. For simulators, it might work with an app built on the same machine. I haven't dug into details for simulators.

— Reply to this email directly, view it on GitHub https://github.com/appium/WebDriverAgent/pull/868#issuecomment-2148079310, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJSY3AF2P6D7R4JPH5TM7LZFX4FTAVCNFSM6AAAAABFCU2SO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBYGA3TSMZRGA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

KazuCocoa commented 4 months ago

Well, for the docs, https://appium.github.io/appium-xcuitest-driver/latest/guides/run-preinstalled-wda/#additional-requirement-for-ios-17tvos17 is for xcrun devicectl device process launch which is for real devices. It may need to address it is only for real devices.

The sim support was added after a while, so some may need to adjust for simulators. I haven't dug into simulator cases so the docs still need to be updated for simulators I believe. It is appreciated to create a PR to improve the docs if you learn new things. We basically update docs when we learn, so it might not be perfect for all cases since it is leaning-basis.