feat: support maxTypingFrequency in settings api

appium / WebDriverAgent

A WebDriver server for iOS and tvOS

Other

1.15k stars 363 forks source link

feat: support maxTypingFrequency in settings api #904

Closed ppken closed 2 months ago

ppken commented 2 months ago

Currently, maxTypingFrequency is supported only in capability. So we can't update it during test execution. So, I added maxTypingFrequency setting to settings api to be able to update it at an arbitrary timing in a test execution.

linux-foundation-easycla[bot] commented 2 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: ppken / name: KAdachi (06c8f7004cd5cb12ab84609876b1f97f8f6bfcca, 75d26ca34ccdee7fdfbb5318d346cbf0a9a822b0)

mykola-mokhnach commented 2 months ago

Thanks @ppken Could you please sign CLA?

ppken commented 2 months ago

@mykola-mokhnach

Could you please sign CLA?

Thank you for your confirmation! I signed CLA but the alerts from CLA don't disappear since the commit is not linked to my account. Let me push the same change with force-push to solve it and then let me address your review comments.

mykola-mokhnach commented 2 months ago

@ppken please don't forget to also update https://github.com/appium/appium-xcuitest-driver/blob/master/docs/reference/settings.md after this PR is merged

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 8.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: