search

appium / appium-docker-android

Appium Server setup to automate android testing on real devices
https://hub.docker.com/r/appium/
Other
605 stars 230 forks source link

Fix build #74

Closed Kignuf closed 6 years ago

Kignuf commented 6 years ago

Build failed at step 21/23 This is due to def5665e9881e0851d160ab01b2c691a8e9320e0 which moved Dockerfile to Appium/ directory

budtmo commented 6 years ago

Thank you @Kignuf for the PR! we really appreciate it!

I think that we do not have any issue with our last build in travis.

Your build failed because you might assume that you need to build the Dockfile from Appium folder, but we build the project from root directory and pass the path of the Dockerfile using -f -> https://github.com/appium/appium-docker-android/blob/master/.travis.yml#L12

But please let us know because I might miss something.

Kignuf commented 6 years ago

Hello butomo, I see what you mean. I made this PR after seing the broken builds on docker hub: https://hub.docker.com/r/appium/appium/builds/ I'm rather new to docker, so I probably missed something here !

SrinivasanTarget commented 6 years ago

@Kignuf It was initially we built it directly on docker hub over each commit but later we changed to build it via travis over each PR or Check in's and push to hub so we could run our unit tests as well there.

Kignuf commented 6 years ago

Thanks for the precision Srinivasan, I closed the PR

SrinivasanTarget commented 6 years ago

@Kignuf you are welcome