Closed kelset closed 1 year ago
linux-foundation-easycla[bot]
commented
1 year ago 
The committers listed above are authorized under a signed CLA.
jlipps
commented
1 year ago Thanks for this update! However opencv4nodejs is not actually required anymore with the new images plugin. I'll go ahead and merge this for posterity. Appium doctor needs to be updated and the checks moved into the appropriate drivers/plugins.
kelset
commented
1 year ago However opencv4nodejs is not actually required anymore with the new images plugin
oh that's a good news, I tried installing it for like 2 hrs yesterday and nothing seemed to work then gave up
jlipps
commented
1 year ago yep, if you use the appium 2 images plugin there is no more dependency on opencv4nodejs, it's all native js now
👋 there
I was just following the guide here http://appium.io/docs/en/about-appium/getting-started/, I tried running the doctor for android to see if my machine was correctly setup and since I don't have opencv4nodejs installed it showed it in the optional fixes; the issue is that the copy points to https://github.com/appium/appium/blob/master/docs/en/writing-running-appium/image-comparison.md which is a broken link.
I scouted around the repo and it looks like there's this https://github.com/appium/appium/blob/master/packages/images-plugin/docs/image-comparison.md but it looks more like it's actually meant to target this page http://appium.io/docs/en/writing-running-appium/image-comparison/ so I changed the url.
I hope that's ok, cheers ✌️