appium / appium-for-mac

[deprecated] Application for automating a mac app with JSON wire protocol
Apache License 2.0
193 stars 70 forks source link

Add some keycodes that needs to set shift to TRUE #73

Closed baochenw closed 4 years ago

baochenw commented 4 years ago

A few symbols are missed in function send_keys() because they need to set shift to TRUE, but not in the keycodes mapping.

Testing Done:

send_keys("`~!@#$%^&*()_+{}|[]\\:\";'<>?,./")
jsf-clabot commented 4 years ago

CLA assistant check
All committers have signed the CLA.

baochenw commented 4 years ago

Could you sign the CLA?

Have signed CLA, but not sure why it is still pending state.

mykola-mokhnach commented 4 years ago

the CLA robot checks the email for the local git account, which created the PR. Please make sure this email is the same the CLA has been signed for

baochenw commented 4 years ago

the CLA robot checks the email for the local git account, which created the PR. Please make sure this email is the same the CLA has been signed for

It is not same, how do I can resign CLA or I have to close this one and request new one?

KazuCocoa commented 4 years ago

You can create another PR which has an email you can use to sign the CLA or rebase the commit

baochenw commented 4 years ago

@KazuCocoa could you please approve again? then I can merge it.

KazuCocoa commented 4 years ago

thanks :)