search

appium / appium-for-mac

[deprecated] Application for automating a mac app with JSON wire protocol
Apache License 2.0
193 stars 70 forks source link

fix: create a diagnostics directory for a proper session #91

Closed KazuCocoa closed 4 years ago

KazuCocoa commented 4 years ago

self.diagnosticsDirectory should be sessionPath in L1900, but L1896 creates directory until the parent directory. So, saving a screenshot like below fails since session-qKXraEAn part haven't been created. directoryPath is /Users/kazuaki/Desktop/AppiumDiagnostics/, sessionPath should be /Users/kazuaki/Desktop/AppiumDiagnostics/session-qKXraEAn/.

[Appium4Mac] [STDERR] 2020-07-07 01:28:20.843 AppiumForMac[10195:4912126] Creating screenshot: /Users/kazuaki/Desktop/AppiumDiagnostics/session-qKXraEAn/element__2020-07-06_16_28_20_+0000.png

This will fix https://github.com/appium/appium-for-mac#screen-shots-for-errors behaviour (Current implementation did not create session-qKXraEAn part so this feature always fails since no directory.)