fix: move UDID between commands and params

appium / appium-idb

idb integration for Appium

Apache License 2.0

75 stars 13 forks source link

fix: move UDID between commands and params #35

Closed dpgraham closed 2 years ago

dpgraham commented 3 years ago

IDB commands seem to only work if udid comes in between the command and the parameters

Example GOOD: idb xctest run ui --udid <SOME_UDID> com.facebook.wda.runner com.facebook.WebDriverAgentRunner.xctrunner com.facebook.WebDriverAgentRunner.xctrunner

BAD: idb xctest run ui com.facebook.wda.runner com.facebook.WebDriverAgentRunner.xctrunner com.facebook.WebDriverAgentRunner.xctrunner --udid <SOME_UDID>

This PR adjusts the createSubProcess function to address this ^

mykola-mokhnach commented 3 years ago

Seems like e2e tests are still unhappy

dpgraham commented 3 years ago

@mykola-mokhnach yeah I think it's unrelated to this PR. I tried from master and got the same result: https://dev.azure.com/AppiumCI/Appium%20CI/_build/results?buildId=11265&view=logs&j=12f1170f-54f2-53f3-20dd-22fc7dff55f9&t=59a85588-b0ba-5043-24c4-d9e29d89c6f6

I'll investigate.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.5.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: