feature request: Add support for Winget installation

appium / appium-inspector

A GUI inspector for mobile apps and more, powered by a (separately installed) Appium server

https://appium.github.io/appium-inspector/

Other

1.19k stars 288 forks source link

feature request: Add support for Winget installation #1274

Open PedromfRibeiro opened 10 months ago

PedromfRibeiro commented 10 months ago

Current Behavior

No package found on Winget, to automate processes and simplify things. Is it possible to add the appium inspector to the Winget repository?

Suggested Solution

PackageIdentifier: Appium.AppiumInspector
PackageVersion: 2023.12.2
Platform:
- Windows.Desktop
InstallerType: nullsoft
InstallModes:
- interactive
- silent
UpgradeBehavior: install
ReleaseDate: 2023-12-02
Installers:
- Architecture: x64
  Scope: user
  InstallerUrl: https://github.com/appium/appium-inspector/releases/download/v2023.12.2/Appium-Inspector-windows-2023.12.2-x64.exe
  InstallerSha256: ??
  InstallerSwitches:
    Custom: /CURRENTUSER
- Architecture: x86
  Scope: machine
  InstallerUrl: https://github.com/appium/appium-inspector/releases/download/v2023.12.2/Appium-Inspector-windows-2023.12.2.exe
  InstallerSha256: ??
  InstallerSwitches:
    Custom: /ALLUSERS
ManifestType: installer
ManifestVersion: ??

Additional Information

No response

eglitise commented 10 months ago

I'm not sure how publishing on Winget works, but I'm going to guess that they won't accept executables without proper signing (#1134)

KazuCocoa commented 10 months ago

@Dor-bl @laolubenson Do you have good resources to learn to publish inspector for Win env via Winget repo? https://github.com/appium/appium-inspector/releases

Dor-bl commented 10 months ago

Sorry, but I haven't worked with winget so far.

I assume a good starting point would be : https://learn.microsoft.com/en-us/windows/package-manager/package/

PedromfRibeiro commented 10 months ago

Referencing PR: https://github.com/microsoft/winget-pkgs/pull/133597 Since Winget is a comunity based input i took the liberty to start the procedure; Steps taken:

cmd -> winget install wingetcreate
cmd -> wingetcreate token
cmd -> wingetcreate new
- Fill informations

jlipps commented 10 months ago

thanks @PedromfRibeiro , looks nice! something seems off with the version reported there in the PR though?

PedromfRibeiro commented 10 months ago

You're welcome @jlipps! True, the version is indeed partially wrong, the PR is waiting for a community moderator to approve it, so i'll try to change it

Change the PackageVersion with the value "2023.12.2.20231220.2" to "2023.12.2", can you confirm?

PedromfRibeiro commented 10 months ago

Well, the PR was aproved right now. I can wait for the next version to update the manifest or make a new PR tomorrow

jlipps commented 10 months ago

yes, 2023.12.2 is correct. actual release versions are found here: https://github.com/appium/appium-inspector/releases