appium / appium-ios-device

Tools for interacting with iOS devices
Apache License 2.0
136 stars 28 forks source link

feat: add xctest class which can be used to start WDA #110

Closed tomriddly closed 1 year ago

tomriddly commented 1 year ago

Code is tested using real device. This is capable of launching WDA along with a additional iproxy process which is not implemented in this library for now.

I'm not sure if xctest.js is placed at a appropriate folder. It's not a utility or service, and it uses lots of predefined service. Eventually I put it as a independent file under lib.

tomriddly commented 1 year ago

I could write the documents if the proper folder and export of xctest is decided

tomriddly commented 1 year ago

Successfully tested on iOS 16/15,but got a failure on 13.6.1.

tomriddly commented 1 year ago

So many constants and string issue. These are mostly from a debug procedure and should not be committed as final code. Deeply sorry wasting @mykola-mokhnach 's time for these annoying code. I will make a cleanup.

mykola-mokhnach commented 1 year ago

So many constants and string issue. These are mostly from a debug procedure and should not be committed as final code. Deeply sorry wasting @mykola-mokhnach 's time for these annoying code. I will make a cleanup.

It is not a problem at all. Main thing we can make it better together. Not even saying about your background investigation in order to reverse engineer and test the approach. @tomriddly, are you interested in becoming the maintainer of this module? Unfortunately we do not have people in our team who have deep knowledge of this topic.

KazuCocoa commented 1 year ago

Successfully tested on iOS 16/15but got a failure on 13.6.1.

I think we can restrict the support versions for the functionality right now (if needed)

tomriddly commented 1 year ago

Successfully tested on iOS 16/15but got a failure on 13.6.1.

I think we can restrict the support versions for the functionality right now (if needed)

Problem was solved by a setTimeout, maybe iPhone7 is too slow. This is theoretically functional on iOS 9~16

tomriddly commented 1 year ago

So many constants and string issue. These are mostly from a debug procedure and should not be committed as final code. Deeply sorry wasting @mykola-mokhnach 's time for these annoying code. I will make a cleanup.

It is not a problem at all. Main thing we can make it better together. Not even saying about your background investigation in order to reverse engineer and test the approach. @tomriddly, are you interested in becoming the maintainer of this module? Unfortunately we do not have people in our team who have deep knowledge of this topic.

I'm not familiar with these stuff. What are the responsibilities of module maintainer? I do have some knowledges about this, but I'm not sure if I'm qualified

tomriddly commented 1 year ago

Tested on major version 12~16.

mykola-mokhnach commented 1 year ago

So many constants and string issue. These are mostly from a debug procedure and should not be committed as final code. Deeply sorry wasting @mykola-mokhnach 's time for these annoying code. I will make a cleanup.

It is not a problem at all. Main thing we can make it better together. Not even saying about your background investigation in order to reverse engineer and test the approach. @tomriddly, are you interested in becoming the maintainer of this module? Unfortunately we do not have people in our team who have deep knowledge of this topic.

I'm not familiar with these stuff. What are the responsibilities of module maintainer? I do have some knowledges about this, but I'm not sure if I'm qualified

The responsibilities are not strict. It is usually necessary to make sure the module still works after a new iOS/Xcode version is released, check/triage possible user issues, and review incoming PRs.

tomriddly commented 1 year ago

So many constants and string issue. These are mostly from a debug procedure and should not be committed as final code. Deeply sorry wasting @mykola-mokhnach 's time for these annoying code. I will make a cleanup.

It is not a problem at all. Main thing we can make it better together. Not even saying about your background investigation in order to reverse engineer and test the approach. @tomriddly, are you interested in becoming the maintainer of this module? Unfortunately we do not have people in our team who have deep knowledge of this topic.

I'm not familiar with these stuff. What are the responsibilities of module maintainer? I do have some knowledges about this, but I'm not sure if I'm qualified

The responsibilities are not strict. It is usually necessary to make sure the module still works after a new iOS/Xcode version is released, check/triage possible user issues, and review incoming PRs.

Sounds good to me. I think I could do this as part-time. What else operations should I do? like join appium organization? or just waiting for a @tomriddly in issue and pr?

mykola-mokhnach commented 1 year ago

Sounds good to me. I think I could do this as part-time. What else operations should I do? like join appium organization? or just waiting for a @tomriddly in issue and pr?

Nothing special. You could join our Slack to discuss dev topics (simply send me your email and you'll get an invitation) and enable watching issues on this repository.

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.5.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: