search

appium / appium-ios-device

Tools for interacting with iOS devices
Apache License 2.0
136 stars 28 forks source link

fix: Prevent possible memory leak on logs collection #114

Closed mykola-mokhnach closed 1 year ago

mykola-mokhnach commented 1 year ago

Related to https://github.com/appium/appium/issues/18566

jlipps commented 1 year ago

or is it that calling Buffer.from puts the memory somewhere that it will not auto release?

mykola-mokhnach commented 1 year ago

lgtm, but which part was a possible memory leak...? utf8CharsAsBytes..? (just to learn properly)

I assume it was strings catenation (result += ... in the previous code). This still needs some more user testing though to confirm, although I find the updated code cleaner and less resource-demanding

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 2.5.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: