search

appium / appium-mac2-driver

Next-gen Appium macOS driver, backed by Apple XCTest
Apache License 2.0
115 stars 24 forks source link

fix: Optional Automation Mode user authentication check #300

Closed a-fultz closed 1 month ago

a-fultz commented 1 month ago

Users running appium driver doctor mac2 are warned to run automationmodetool enable-automationmode-without-authentication based on whether the system is in Automation Mode at the time of the check, not whether user authentication is required for it. From the automationmodetool man page:

If no argument is passed, the tool prints the current status of Automation Mode (enabled or disabled), the authentication configuration (required or not), and then exits.

Example:

% automationmodetool
Automation Mode is disabled.
This device DOES NOT REQUIRE user authentication to enable Automation Mode.

This PR changes the stdout check to 'DOES NOT REQUIRE' and inverts the warning logic.

Note: This code is untested. I do not have a local development environment for Appium or Appium drivers.

linux-foundation-easycla[bot] commented 1 month ago

CLA Signed


The committers listed above are authorized under a signed CLA.

github-actions[bot] commented 1 month ago

:tada: This PR is included in version 1.17.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: