search

appium / appium-remote-debugger

Module for dealing with Remote Debugger protocol
Apache License 2.0
43 stars 32 forks source link

feat: update atoms to selenium 4.19.0 basis #375

Closed KazuCocoa closed 2 months ago

KazuCocoa commented 2 months ago

Diffs:

mykola-mokhnach commented 2 months ago

It would be nice if we could add an e2e test for the react input case for the future

KazuCocoa commented 2 months ago

Sounds good. Let me check Jlipps's thoughts as well in https://github.com/appium/appium-remote-debugger/pull/376 If the react workaround in Appium makes sense, will merge the PR to this branch, and then will merge this to master to publish a new one. (Agree with the test, bsaically)

KazuCocoa commented 2 months ago

I'm going to merge this only since I have closed https://github.com/appium/appium-remote-debugger/pull/376 and moving to https://github.com/appium/appium/issues/20004#issuecomment-2059754083 idea for this case. I think it is better than adding atoms's customization only in Appium Atoms.

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 11.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

KazuCocoa commented 2 months ago

Oh, do you mean https://github.com/SeleniumHQ/selenium/pull/12704 ...? Actually it reverted https://github.com/SeleniumHQ/selenium/pull/12557 .

Hm, shall we apply https://github.com/SeleniumHQ/selenium/pull/12557 to our appium atoms? @jlipps

yea, CI here and https://github.com/appium/appium-xcuitest-driver were fine with this.

KazuCocoa commented 2 months ago

ah, maybe typeof window .... related errors? Then yea, I removed them to remove diffs after creating atoms on this pr. So actually your fix was applied to this atoms.

Maybe we should note it in this atoms note. -> https://github.com/appium/appium-remote-debugger/blob/master/atoms-notes.md Updated

jlipps commented 2 months ago

yep exactly. thanks!