appium / appium-uiautomator2-driver

Appium driver for Android UIAutomator2
Apache License 2.0
519 stars 170 forks source link

ci: use GH Action for detecting LTS Node #771

Closed eglitise closed 2 months ago

eglitise commented 2 months ago

Same as https://github.com/appium/appium/pull/20059. Also adjusted unit tests to be skipped for Markdown file changes.

mykola-mokhnach commented 2 months ago

It looks like functional tests don't work anymore. Could you please try also bumping the java version there to 17?

eglitise commented 2 months ago

Seems like the architecture also needs to be changed? Unsure...

mykola-mokhnach commented 2 months ago

PANIC: Avd's CPU Architecture 'x86' is not supported by the QEMU2 emulator on aarch64 host.

Yes, looks like GH switched to use ARM runners now. This should be good news through - they should perform much better than intel ones

mykola-mokhnach commented 2 months ago

Or maybe we can switch to KVM runners: https://github.com/ReactiveCircus/android-emulator-runner?tab=readme-ov-file#running-hardware-accelerated-emulators-on-linux-runners

mykola-mokhnach commented 2 months ago

Actually we may try to copy the related changes from https://github.com/appium/appium-uiautomator2-driver/actions/runs/8919253215/job/24495129792?pr=770

That one only needs the xq tool and Andoid SDK to be installed. The first one could be done via apt-get: sudo apt-get -qq install xq The second one: https://github.com/android-actions/setup-android

eglitise commented 2 months ago

In that case maybe it's better if I revert the functional test changes in this PR, so they can be done entirely in Kazu's PR? Same for the Espresso driver PR.

KazuCocoa commented 2 months ago

Yea, let me check the KVM runner stuff in https://github.com/appium/appium-uiautomator2-driver/pull/770 This PR currently can focus on nodejs stuff, looks reasonable to me

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 3.2.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: