Added support for keyboard/mouse on Actions

[WhesRC]

The Mouse and Keyboard interface are deprecated under latest appium version Actions done under those interfaces are now under the Actions umbrella but winappDriver had no support for it.

Redirected the actions to the right endpoints from the winAppDriver

Not sure If I mapped all the actions under the Mouse interface (I mainly needed support for actions under the drag&drop methods umbrella. Should be easy to map new endpoints if I missed something)

[linux-foundation-easycla[bot]]

• :x: The commit (997f083de8c213bdf48c4bed1a0a3b9971f8cf97, 957dc939047242a994f02a805d800459a066cf82, a533c53d096b2516381b04b11d252ede50d14bc8, b12ba01ee1303fe1d85bb28c28669f50d4c83c4e, 125dd8a0399753e91291817270f7aaf299038e08, da89d6de9babbc68cebdbefb812a632ee4d2dd0f). This user is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[mykola-mokhnach]

Just to reiterate on the topic:

WinAppDriver DOES support W3C actions, but limits available inout sources: https://github.com/microsoft/WinAppDriver/blob/master/Tests/WebDriverAPI/Actions.cs https://github.com/microsoft/WinAppDriver/blob/master/Tests/WebDriverAPI/ActionsTouch.cs https://github.com/microsoft/WinAppDriver/blob/master/Tests/WebDriverAPI/ActionsPen.cs

It also supports several shortcuts of legacy JWP touch interactions: https://github.com/microsoft/WinAppDriver/blob/master/Tests/WebDriverAPI/TouchClick.cs https://github.com/microsoft/WinAppDriver/blob/master/Tests/WebDriverAPI/TouchDoubleClick.cs https://github.com/microsoft/WinAppDriver/blob/master/Tests/WebDriverAPI/TouchDownMoveUp.cs https://github.com/microsoft/WinAppDriver/blob/master/Tests/WebDriverAPI/TouchFlick.cs https://github.com/microsoft/WinAppDriver/blob/master/Tests/WebDriverAPI/TouchLongClick.cs https://github.com/microsoft/WinAppDriver/blob/master/Tests/WebDriverAPI/TouchScroll.cs

So, here we need to:

• Decide subset of (unsupported) W3C actions we are going to convert and document that subset
• Decide on the actions conversion limitations (e.g. which actions/input sources do we support and which we don't, whether we support multitouch, etc), document them and add examples
• Add TODOs for the future if/when WAD starts to fully support W3C standard, so our workarounds could be safely removed

[WhesRC]

Ola @mykola-mokhnach Could you have a fresh look over things, wanted to see which of the comments are still relevant. Let me know what else stick out to you. Regarding the documentation. All the actions that worked before still work with the changes, and I specified in comment the extra actions that now work with this. Not sure if a comment is the best way to have them documented tho, or if the format is right. Also, this offers support for "actions" that worked before with the old appium version, before W3C enforcement. I am not trying to implement full support to w3c actions, just trying to make sure that what worked before still has a way of working.

[mykola-mokhnach]

Regarding the documentation. All the actions that worked before still work with the changes, and I specified in comment the extra actions that now work with this. Not sure if a comment is the best way to have them documented tho, or if the format is right.

I would appreciate it if we had a markdown document in https://github.com/appium/appium-windows-driver/tree/master/docs, which describes all current limitations of actions transformation along with examples, e.g.

the following w3c actions are supported
single mouse click by coordinates:  w3c actions example
right mouse click on element by relative coordinates: w3c actions example

The second thing I would love to see is a set of unit tests that verifies that given w3c action chains are being properly transformed to the expected legacy command sets

[WhesRC]

I will create the markdown document and the unit tests, tho I will only have time to do that end of last week. Let me know if anything else from the rest of the things is not changed ok

[hellozyemlya]

@WhesRC any updates here?

[mykola-mokhnach]

Closed in favour of https://github.com/appium/appium-windows-driver/pull/163