appium / dotnet-client

Extension to the official Selenium dotnet webdriver
Apache License 2.0
378 stars 187 forks source link

I am unable to use openNotifications with Appium Driver #497

Closed aaronportier closed 1 year ago

aaronportier commented 2 years ago

Description

I am unable to get the Driver to work with openNotifications. It will work with Python. does not contain a definition for openNotification and no accessible extension method I am using C# I am using the Appium Nugget Package most recent via Visual Studio

Environment

Please provide more details, if necessary.

Code To Reproduce Issue [ Good To Have ]

_driver.openNotification()

Dor-bl commented 2 years ago

@aaronportier I assume you are referring to Android Driver. if that's the case you should try using OpenNotifications(). Are you using the v5.0.0-beta01 Package? @akinsolb I think we should add an Integration test for that action.

aaronportier commented 2 years ago

I'm using the latest stable. Open notifications does not seem to work though.

On Wed, Aug 31, 2022, 5:20 PM Dor Blayzer @.***> wrote:

@aaronportier https://github.com/aaronportier I assume you are referring to Android Driver. if that's the case you should try using OpenNotifications(). Are you using the v5.0.0-beta01 https://github.com/appium/appium-dotnet-driver/releases/tag/v5.0.0-beta01 Package? @akinsolb https://github.com/akinsolb I think we should add an Integration test for that action.

— Reply to this email directly, view it on GitHub https://github.com/appium/appium-dotnet-driver/issues/497#issuecomment-1233433072, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGVOYNEBI5C3YJQW5Q42H3V37ECBANCNFSM5YKEHYXQ . You are receiving this because you were mentioned.Message ID: @.***>

Dor-bl commented 2 years ago

It just won't work or you can't find a matching method? Did you tried with the release version I sent?

aaronportier commented 2 years ago

I will try tomorrow for the now I just pull down the shade by coordinates but open notifications is not usable and Open notifications does not do anything.

On Wed, Aug 31, 2022, 5:36 PM Dor Blayzer @.***> wrote:

It just won't work or you can't find a matching method? Did you tried with the release version I sent?

— Reply to this email directly, view it on GitHub https://github.com/appium/appium-dotnet-driver/issues/497#issuecomment-1233445047, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABGVOYO74JGUUPBTX7SDUADV37F4VANCNFSM5YKEHYXQ . You are receiving this because you were mentioned.Message ID: @.***>

laolubenson commented 2 years ago

@aaronportier @Dor-bl This feature is only supported on emulators only.

Dor-bl commented 2 years ago

So I think we can close this issue. Unless something we can do on the .NET side in order to support as Python does. @mykola-mokhnach any Input?

laolubenson commented 2 years ago

This works for physical devices on python client? @KazuCocoa is there a secret?

KazuCocoa commented 2 years ago

The endpoint calls https://developer.android.com/reference/androidx/test/uiautomator/UiDevice#opennotification , so the behavior depends on Android OS internals. Maybe .net client has the endpoint call https://github.com/appium/appium-dotnet-driver/blob/4570d11267572b861554142d39d4452d853e6118/src/Appium.Net/Appium/AppiumCommand.cs#L69 ...?

Python client also just calls the endpoint: https://github.com/appium/python-client/blob/ce4de83b443b050e295c5c1af0938ce720198bc8/appium/webdriver/extensions/android/common.py#L43-L50

Dor-bl commented 1 year ago

@akinsolb @aaronportier just tested it on my device and it worked just fine. added a test for it as well along the way. see : https://github.com/appium/appium-dotnet-driver/pull/546

Dor-bl commented 1 year ago

Closed as unreproducible.