I saw a ticekt in selenium repo that they are going to add ClientConfig (currently Java client has), so as same as https://github.com/appium/java-client/pull/1747, I have added AppiumClientConfig to keep client side config so that we'll be able to inherit the selenium project's one when they introduce it. Then, we will not need to add a new constructor.
(With this, all of our clients and webdrierio support this.)
Types of changes
What types of changes are you proposing/introducing to .NET client?
Put an x in the boxes that apply
[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] New feature (non-breaking change which adds value to the project)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
Documentation
[ ] Have you proposed a file change/ PR with appium to update documentation?
This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example
Integration tests
[ ] Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)
Details
Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they
work and possible use cases. Also you can create gists with pasted C# code samples or put them here using markdown.
About markdown please read Mastering markdown and Writing on GitHub
Change list
Add https://github.com/appium/java-client/pull/1747 for dotnet client.
Copy from the ticket:
I'd like to add https://appiumpro.com/editions/86-connecting-directly-to-appium-hosts-in-distributed-environments for Java client. Other clients such as webdriverio, Ruby and Python already have them for long. If the response had directConnect capabilities, the appium client attempt to send requests to the directConnect one instead of the original URL.
or
appium:
prefixed ones.I saw a ticekt in selenium repo that they are going to add ClientConfig (currently Java client has), so as same as https://github.com/appium/java-client/pull/1747, I have added
AppiumClientConfig
to keep client side config so that we'll be able to inherit the selenium project's one when they introduce it. Then, we will not need to add a new constructor.(With this, all of our clients and webdrierio support this.)
Types of changes
What types of changes are you proposing/introducing to .NET client? Put an
x
in the boxes that applyDocumentation
This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example
Integration tests
Details
Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they work and possible use cases. Also you can create gists with pasted C# code samples or put them here using markdown. About markdown please read Mastering markdown and Writing on GitHub