appium / dotnet-client

Extension to the official Selenium dotnet webdriver
Apache License 2.0
381 stars 187 forks source link

feat: add directConnect feature #627

Closed KazuCocoa closed 1 year ago

KazuCocoa commented 1 year ago

Change list

Add https://github.com/appium/java-client/pull/1747 for dotnet client.

Copy from the ticket:


I'd like to add https://appiumpro.com/editions/86-connecting-directly-to-appium-hosts-in-distributed-environments for Java client. Other clients such as webdriverio, Ruby and Python already have them for long. If the response had directConnect capabilities, the appium client attempt to send requests to the directConnect one instead of the original URL.

or appium: prefixed ones.


I saw a ticekt in selenium repo that they are going to add ClientConfig (currently Java client has), so as same as https://github.com/appium/java-client/pull/1747, I have added AppiumClientConfig to keep client side config so that we'll be able to inherit the selenium project's one when they introduce it. Then, we will not need to add a new constructor.

(With this, all of our clients and webdrierio support this.)

Types of changes

What types of changes are you proposing/introducing to .NET client? Put an x in the boxes that apply

Documentation

Integration tests

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples which show the way they work and possible use cases. Also you can create gists with pasted C# code samples or put them here using markdown. About markdown please read Mastering markdown and Writing on GitHub

Dor-bl commented 1 year ago

@KazuCocoa LGTM, After you merge I'll rebase and update my PR for public Response Execute(Command commandToExecute)

KazuCocoa commented 1 year ago

thank you!