search

appium / dotnet-client

Extension to the official Selenium dotnet webdriver
Apache License 2.0
381 stars 187 forks source link

[Feat]: 5.0 release #726

Closed KazuCocoa closed 3 months ago

KazuCocoa commented 8 months ago

@Dor-bl @laolubenson do you think we can make the 5 RC.5 to stable release... (as no blocking known issues)?

Dor-bl commented 8 months ago

@KazuCocoa we have this bug which I prefer to fix before the stable release: https://github.com/appium/dotnet-client/issues/724

KazuCocoa commented 8 months ago

I see. Thank you!

Dor-bl commented 8 months ago

@KazuCocoa I've just released V5 RC.5, if no new issues arise I assume the next version can be the stable one. However, I think I first need to remove the obsolete methods we've been dragging for some time now, e.g. TouchAction, LaunchApp, ReplaceValue

jamesmcroft commented 7 months ago

Appium team, I have a question which could be a separate issue (happy to create if needs be) that I wanted to ask here around 5.0.

With Selenium still supporting .NET Standard 2.0, was there a specific reason to move to .NET 6.0 with this library? Apologies if I have missed this.

Dor-bl commented 7 months ago

The primary reason for transitioning to .NET 6 was to enable the execution of this project on a new Mac machine. The compatibility between .NET Framework 4.8 and Visual Studio Code with the C# Dev Kit was proving to be problematic.

Dor-bl commented 6 months ago

@KazuCocoa, I hope rc.7 will be the last RC version. I still need to prepare a draft for the stable release of 5.x so it might take some time.

mialeska commented 5 months ago

@Dor-bl Could netstandard2.0 be restored as an additional target framework? I can see there still are some properties in your csproj that use it in conditions: image I am interested because in my case, I am supporting appium-wrapper library that uses netstandart2.0 as a target, to make it compatible to both .NET core and .NET Framework.

Dor-bl commented 5 months ago

@mialeska, I assume it can be done, I just need to run a few tests before. @laolubenson, Do you see any downside with adding .NET Standard 2.0 back?

Dor-bl commented 3 months ago

https://github.com/appium/dotnet-client/releases/tag/v5.0.0 is now available. Closing as completed.