appium / dotnet-client

Extension to the official Selenium dotnet webdriver
Apache License 2.0
381 stars 187 forks source link

refactor: reintroduce the .NET Framework 4.8 target framework #740

Closed Dor-bl closed 7 months ago

Dor-bl commented 7 months ago

List of changes

I've been contacted by numerous people saying the fact we dropped the support for .NET Framework 4.8 has blocked them from upgrading to latest RC versions With this PR we should be able to have backward compatability with the Net48

Types of changes

What types of changes are you proposing/introducing to the .NET client? Put an x in the boxes that apply

Documentation

Integration tests

Details

Please provide more details about changes if it is necessary. If there are new features you can provide code samples showing how they work and possible use cases. Also, you can create gists with pasted C# code samples or put them here using markdown. About markdown please read Mastering markdown and Writing on GitHub

Dor-bl commented 7 months ago

@MartyIX your feedback would be great if possible.

MartyIX commented 7 months ago

In general, code looks OK to me. But I have not tested the PR.