Implementing ICommandExecutor's ExecuteAsync() and using it in Execute()

kelmelzer commented 6 days ago

I think this should fix it in Selenium 4.22+, but its untested so far of course. :)

List of changes

Implemented ICommandExecutor's ExecuteAsync(). Moved Execute() code to there and call it from Execute() with Task.Run()

Types of changes

What types of changes are you proposing/introducing to the .NET client? Put an x in the boxes that apply

[x] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] New feature (non-breaking change which adds value to the project)
[ ] Breaking change (fix or feature that would cause existing functionality not to work as expected)

Documentation

[ ] Have you proposed a file change/ PR with appium to update documentation?
This can be done by navigating to the documentation section on http://appium.io selecting the appropriate command/endpoint and clicking the 'Edit this doc' link to update the C# example

Integration tests

[ ] Have you provided integration tests to pass against the beta version of appium? (for Bugfix or New feature)

linux-foundation-easycla[bot] commented 6 days ago

:white_check_mark:login: kelmelzer / (0d878bd17a78de707538670e4d51cc0d16a51f5d)

The committers listed above are authorized under a signed CLA.

Dor-bl commented 6 days ago

@kelmelzer, thank you for your contribution. In order for the build to pass, you will need to update the selenium dependencies as part of this PR.

kelmelzer commented 21 hours ago

@kelmelzer, thank you for your contribution. In order for the build to pass, you will need to update the selenium dependencies as part of this PR.

Sure thing. I did that by hand but will fork it and actually build it on my personal machine shortly :)

Dor-bl commented 21 hours ago

@kelmelzer, thank you for your contribution. In order for the build to pass, you will need to update the selenium dependencies as part of this PR.

Sure thing. I did that by hand but will fork it and actually build it on my personal machine shortly :)

This will not work for you because the Selenium team needs to fix the encapsulation they broke on internal Response Execute. So it would be best if you waited for the next release.

kelmelzer commented 20 hours ago

Closing pull request. I made a new one which fixes the build and wraps ExecuteAsync() properly

appium / dotnet-client