appium / io.appium.settings

App for dealing with Android settings
Apache License 2.0
122 stars 56 forks source link

fix: Stop media projection when stopping recording #193

Closed igokoro closed 1 month ago

igokoro commented 1 month ago

Context

Running long and/or large test suites with screen recording for each test sometimes fails on screen recording start/stop: the media projection used for screen recording is never stopped, so after running for about an hour, the appium settings app must be killed before the screen recording starts working again.

This can also be reproduced by running a single test with screen recoding, then leaving the device idle for a while (notice that screen recording status bar icon never disappears) and then running the test again.

Fix

Call mediaProjection.stop() when screen recording is stopped. This makes sure that system resources are released and media projection is properly cleaned up.

linux-foundation-easycla[bot] commented 1 month ago

CLA Signed


The committers listed above are authorized under a signed CLA.

github-actions[bot] commented 1 month ago

:tada: This issue has been resolved in version 5.12.11 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

KazuCocoa commented 1 month ago

uia2 driver 3.7.7 has this change

jlipps commented 2 weeks ago

Hi @igokoro , congrats, the Appium project wants to compensate you for this (and perhaps other) contribution(s) this month! Please reply to this comment mentioning me and sharing your OpenCollective account name, so that we can initiate payment! Or let me know if you decline to receive compensation via OpenCollective. Thank you!