Caching Mechanism for ProxyListenerContainer

appium / java-client

Java language binding for writing Appium Tests, conforms to W3C WebDriver Protocol

Apache License 2.0

1.2k stars 755 forks source link

Caching Mechanism for ProxyListenerContainer #1969

Closed Auto81 closed 1 year ago

Auto81 commented 1 year ago

Change list

Updating the ProxyListenerContainer to use a LinkedHashMap caching mechanism, in place of a List. This is to improve performance as the amount of listeners grows.

I have defaulted the cache to 5000 decorated pages, but this can be changed if needed through a system property

Types of changes

What types of changes are you proposing/introducing to Java client?

[x] Bugfix (non-breaking change which fixes an issue)

Details

Original Discussion

linux-foundation-easycla[bot] commented 1 year ago

:x: The email address for the commit (b66d0cde326f0ddbf1fa110c89451a1d6791924e, 5fdf74e7e3225bd90c785b8990caeba8185dd681, a0f6aaabd294c7e51862e4c3f1766b513aff73ed) is not linked to the GitHub account, preventing the EasyCLA check. Consult this Help Article and GitHub Help to resolve. (To view the commit's email address, add .patch at the end of this PR page's URL.) For further assistance with EasyCLA, please submit a support request ticket.

mykola-mokhnach commented 1 year ago

@Auto81 Do you have any particular updates on this issue after checking the memory leak? Do you think it is still something that could be addressed from the java client perspective?

Auto81 commented 1 year ago

@Auto81 Do you have any particular updates on this issue after checking the memory leak? Do you think it is still something that could be addressed from the java client perspective?

Have just updated the discussion at https://github.com/appium/appium/discussions/18860