Closed fishey2 closed 1 year ago
Could you please sign CLA?
I should have now signed the CLA
In order to not make this change breaking it would make sence to mark method names containing typos as @Deprecated
and keep them for now along with corrected ones. We could remove deprecated methods in later releases.
The changes should reflect your suggestion now @mykola-mokhnach: Deprecated rather than remove methods containing typos.
@valfirst happy to work around the Checkstyle issue, however the actual checkstyle issue is apparent because it thinks the deprecated method setCustomSSLCert()
overloads setCustomSSLCert(String)
instead of getCustomSSLCert()
, which should have been the case.
In this case there is only the two methods in the class and moving it up shouldn't affect anything else, but workaround the checkstyle issue. I will push this change now.
Change list
SupportsCustomSslCertOption
methodsetCustomSSLCert()
is nowgetCustomSSLCert()
affectsXCUITestOptions
SupportsSimulatorTracePointerOption
methoddoesSimulatorTracePointerd()
is nowdoesSimulatorTracePointer()
affectsXCUITestOption
SupportsShowChromedriverLogOption
methodssetDhowChromedriverLog(boolean)
anddoesDhowChromedriverLog()
are nowsetShowChromedriverLog(boolean)
anddoesShowChromedriverLog()
respectively affectsExpressoOptions
andUIAutomator2Options
Types of changes
What types of changes are you proposing/introducing to Java client? Put an
x
in the boxes that applyDetails
No functional changes