appium / java-client

Java language binding for writing Appium Tests, conforms to W3C WebDriver Protocol
Apache License 2.0
1.2k stars 755 forks source link

fix: Correct spelling and semantic mistakes in method naming #1970

Closed fishey2 closed 1 year ago

fishey2 commented 1 year ago

Change list

Types of changes

What types of changes are you proposing/introducing to Java client? Put an x in the boxes that apply

Details

No functional changes

linux-foundation-easycla[bot] commented 1 year ago

CLA Missing ID CLA Not Signed

mykola-mokhnach commented 1 year ago

Could you please sign CLA?

fishey2 commented 1 year ago

I should have now signed the CLA

mykola-mokhnach commented 1 year ago

In order to not make this change breaking it would make sence to mark method names containing typos as @Deprecated and keep them for now along with corrected ones. We could remove deprecated methods in later releases.

fishey2 commented 1 year ago

The changes should reflect your suggestion now @mykola-mokhnach: Deprecated rather than remove methods containing typos.

fishey2 commented 1 year ago

@valfirst happy to work around the Checkstyle issue, however the actual checkstyle issue is apparent because it thinks the deprecated method setCustomSSLCert() overloads setCustomSSLCert(String) instead of getCustomSSLCert(), which should have been the case.

In this case there is only the two methods in the class and moving it up shouldn't affect anything else, but workaround the checkstyle issue. I will push this change now.