appium / java-client

Java language binding for writing Appium Tests, conforms to W3C WebDriver Protocol
Apache License 2.0
1.2k stars 753 forks source link

fix: Fix Code style issues to match Java standards #2017

Closed ashwithpoojary98 closed 11 months ago

ashwithpoojary98 commented 11 months ago

Change list

Types of changes

What types of changes are you proposing/introducing to Java client? Put an x in the boxes that apply

Details

To meet Java code standards, I made a few changes to method and class-level variables: Added a Lombok no-arg constructor with private access to restrict the user from creating a new object of the class, since this class consists of all static methods. Added override annotations to improve the readability of methods and removed additional code from lambda expressions.

linux-foundation-easycla[bot] commented 11 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

mykola-mokhnach commented 11 months ago

Thank you @ashwithpoojary98 Please rename the PR to follow https://www.conventionalcommits.org/en/v1.0.0/ Also please make sure you have signed the CLA

ashwithpoojary98 commented 11 months ago

@mykola-mokhnach Thanks for reviewing the PR. I updated the code as per your comments. Please review.

ashwithpoojary98 commented 11 months ago

updated the workflow issue

ashwithpoojary98 commented 11 months ago

Updated workflow issue

ashwithpoojary98 commented 11 months ago

The Boolean check type casting issue was reverted.

ashwithpoojary98 commented 11 months ago

All checks have passed!!