appium / java-client

Java language binding for writing Appium Tests, conforms to W3C WebDriver Protocol
Apache License 2.0
1.2k stars 753 forks source link

fix: Change scope of `selenium-support` dependency to `compile` #2019

Closed valfirst closed 11 months ago

valfirst commented 11 months ago

Change list

Fixes #2012.

AppiumFluentWait (which is a part of Appium Java Client API) extends FluentWait from selenium-support dependency, thus this dependency must be in compile classpath.

Types of changes

What types of changes are you proposing/introducing to Java client?

Details

https://docs.gradle.org/current/userguide/java_library_plugin.html#sec:java_library_separation:

Dependencies appearing in the api configurations will be transitively exposed to consumers of the library, and as such will appear on the compile classpath of consumers. Dependencies found in the implementation configuration will, on the other hand, not be exposed to consumers, and therefore not leak into the consumers' compile classpath.