chore: Automate more static code checks - Githubissues

appium / java-client

Java language binding for writing Appium Tests, conforms to W3C WebDriver Protocol

Apache License 2.0

1.2k stars 753 forks source link

chore: Automate more static code checks #2028

Closed valfirst closed 11 months ago

valfirst commented 11 months ago

Change list

It's better to prevent code style violations instead of fixing them. The aim of this PR is to automate checks for code style fixes from #2017.

Types of changes

What types of changes are you proposing/introducing to Java client?

[x] No changes in production code.
[ ] Bugfix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Enabled Checkstyle rules to cover all cases from #2017.
Fixed all leftovers.
Checkstyle doesn't play well with Lombok (https://github.com/checkstyle/checkstyle/issues/13508, https://github.com/checkstyle/checkstyle/issues/2579), the easiest solution is to replace Lombok with native Java code.