Added ByWindowsAutomation to AppiumBy.java

itaibh commented 8 months ago

Change list

Added ByWindowsAutomation to AppiumBy.

Types of changes

What types of changes are you proposing/introducing to Java client? Put an x in the boxes that apply

[ ] No changes in production code.
[ ] Bugfix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Until version 8.6 there was the MobileBy class which had all the features now moved to AppiumBy, but not all features were migrated there. I added the missing ByWindowsAutomation that existed in the now removed MobileBy and was provided no replacement.

linux-foundation-easycla[bot] commented 8 months ago

The committers listed above are authorized under a signed CLA.

:white_check_mark: login: itaibh / name: Itai Bar-Haim (e31b20639e3f5f82942963b355ddb0ee546afecf)

mykola-mokhnach commented 8 months ago

This locator has been deprecated and removed deliberately as it was not used anywhere

itaibh commented 8 months ago

@mykola-mokhnach How can you tell for sure it wasn't used anywhere? I have a code that is using it.

mykola-mokhnach commented 8 months ago

Just to be precise - it was not used in any drivers that we maintain. Of course there might be third party drivers we don't know about and they may use different locator types. The idea was for that we introduce more flexible system where corresponding drivers may also define custom locator types, so there is a clear relationship between them.

itaibh commented 8 months ago

ok, I see. thanks.

appium / java-client