appium / java-client

Java language binding for writing Appium Tests, conforms to W3C WebDriver Protocol
Apache License 2.0
1.18k stars 752 forks source link

feat: add pollDelay mechanism into AppiumFluentWait #2116

Closed AlessandroMiccoli closed 4 months ago

AlessandroMiccoli commented 4 months ago

Change list

Please provide briefly described change list which are you going to propose.

Types of changes

What types of changes are you proposing/introducing to Java client? Put an x in the boxes that apply

Details

These changes will allow the AppiumFluentWait to sleep for a defined pollDelay before starting to verify the condition is true. It includes a little refactor to the until method, so it will be more readable.

AlessandroMiccoli commented 4 months ago

@mykola-mokhnach is there something else I need to do for merging this PR?

mykola-mokhnach commented 4 months ago

it looks like CI became unhappy

mykola-mokhnach commented 4 months ago

@mykola-mokhnach is there something else I need to do for merging this PR?

Yes, a little bit of patience ;-). We check it as soon as there is some free time

AlessandroMiccoli commented 4 months ago

A length rule failed in the pipeline. What do you use for checking the rules? Do you use the Google standard styling rules?