Closed himanshunikhare25 closed 1 year ago
The committers listed above are authorized under a signed CLA.
Awesome! What version of mitm-proxy is it working with? The readme specifies v4, so if this now works with a later version, can you update the readme as well?
@Jonahss below are the details for mitm-proxy version used by me during the development for above PR.
Mitmproxy: 9.0.1
Python: 3.10.9
OpenSSL: OpenSSL 3.0.7 1 Nov 2022
Platform: macOS-13.2.1-arm64-arm-64bit
Updated the same to README.md
Super! Now I understand why people have been reporting problems. Everyone will be happy to update :D
Fix contains 5 major changes for proxy to run perfectly on mac. This is my first PR, please correct/guide me if there is any issues with the PR.
1. Removed JCenter
2. Used hasProperty instead of directly accessing property in authentication
Build was failing because no property was set for
ossrhUsername
andossrhPassword
3. Moved sign configurations.archives inside setRequired block
Signing is only required if the artifacts are to be published.
4. Replaced http.HTTPResponse.make with http.Response.make as The mitmproxy API seems to have changed and the syntax is now http.Response.make()
5. Updated MITMDUMP_PATH for mac
Post all fixed all tests are passing perfectly in mac machine