appium / ruby_lib_core

Core library for the Ruby client
Apache License 2.0
31 stars 24 forks source link

tweaking orientation module #454

Closed KazuCocoa closed 1 year ago

KazuCocoa commented 1 year ago

https://github.com/appium/ruby_lib_core/blob/65a56e484da47cd000c72222f80b74111e381e27/lib/appium_lib_core/common/base/rotable.rb#L23

:landscape_right and :portrait_upside_down can adds. then convert them to:

const struct FBWDOrientationValues FBWDOrientationValues = {
  .portrait = @"PORTRAIT",
  .landscapeLeft = @"LANDSCAPE",
  .landscapeRight = @"UIA_DEVICE_ORIENTATION_LANDSCAPERIGHT",
  .portraitUpsideDown = @"UIA_DEVICE_ORIENTATION_PORTRAIT_UPSIDEDOWN",
};
KazuCocoa commented 1 year ago

https://github.com/appium/ruby_lib_core/commit/dd2f87a8c6da7c2b88290f3fd5813a0ffb545694