search

appium / ruby_lib_core

Core library for the Ruby client
Apache License 2.0
31 stars 24 forks source link

feat: add ::Selenium::WebDriver::Support::AbstractEventListener support as Appium::Support::EventFiringBridge #456

Closed KazuCocoa closed 1 year ago

KazuCocoa commented 1 year ago

Part of https://github.com/appium/ruby_lib_core/issues/455

Potentially this is sufficient. I haven't tested yet.

KazuCocoa commented 1 year ago

I think almost done.

@tayrawr Could you try out this branch?

As the test code, a subclass of ::Selenium::WebDriver::Support::AbstractEventListener.new as listener may work via ::Appium::Support::EventFiringBridge which inherits Selenium's one.

tayrawr commented 1 year ago

@KazuCocoa, from my tests so far, everything seems great! I was able to create a listener and trigger its event methods.

KazuCocoa commented 1 year ago

FYI: v6.3.0 has this change