appknox / irene

I AM SHER LOCKED. Dashboard for Appknox Users.
https://secure.appknox.com
GNU Affero General Public License v3.0
20 stars 11 forks source link

security analysis details page revamp #1400

Closed Yibaebi closed 4 months ago

coderabbitai[bot] commented 5 months ago

Walkthrough

This update introduces a comprehensive set of new components and enhancements for managing security analysis within an application. Key features include components for handling file attachments, displaying and interacting with CVSS metrics, adding and managing findings, and structuring the layout of security analysis details. Various methods and properties are defined to interact with services, handle tasks, and update UI elements dynamically.

Changes

File(s) Change Summary
...security/analysis-details/attachments/index.* Introduced components for managing file attachments, with upload, download, and deletion functionalities.
...security/analysis-details/cvss-metrics/index.* Added components for displaying and interacting with CVSS metrics, including a clear option and risk labels.
...security/analysis-details/findings/add-form/* Introduced components for adding new findings in security analysis, including form handling and validation.
...security/analysis-details/findings/table/* Added table components for displaying and managing findings, including descriptions and action buttons.
...security/analysis-details/footer/index.* Introduced a footer component for the security analysis details section, with save and continue options.
...security/analysis-details/header/index.* Added a header component for displaying analysis details, including status updates and confirmation dialogs.
...security/analysis-details/index.* Introduced a structured layout for security analysis details, integrating various sub-components seamlessly.
...security/analysis-details/regulatory-categories/index.* Added components for displaying and selecting regulatory categories related to security analysis.
app/helpers/metric-vector.ts Introduced a helper function for mapping input parameters to specific string values based on predefined ENUMS.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant FileService
    participant AnalysisService
    User->>UI: Upload File
    UI->>FileService: Trigger File Upload
    FileService-->>UI: File Upload Successful
    UI-->>User: Display Uploaded File

    User->>UI: Add Finding
    UI->>AnalysisService: Save Finding
    AnalysisService-->>UI: Finding Saved
    UI-->>User: Display New Finding
sequenceDiagram
    participant User
    participant UI
    participant MetricsService
    User->>UI: View CVSS Metrics
    UI->>MetricsService: Fetch CVSS Metrics
    MetricsService-->>UI: Return Metrics Data
    UI-->>User: Display CVSS Metrics

    User->>UI: Clear CVSS Metrics
    UI->>MetricsService: Clear Metrics
    MetricsService-->>UI: Clear Confirmation
    UI-->>User: Metrics Cleared

Poem

In the realm of security, we dance with care,
Files to upload, findings to share.
Metrics we track, in a structured stack,
With categories to guide us, there's no looking back.
A footer to save us, a header so bright,
Our code now stands, a fortress of light.
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cloudflare-workers-and-pages[bot] commented 5 months ago

Deploying irenestaging with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9598bae
Status: âœ…  Deploy successful!
Preview URL: https://135e6843.irenestaging.pages.dev
Branch Preview URL: https://pd-1279-refactor-sec-analysi.irenestaging.pages.dev

View logs

cypress[bot] commented 5 months ago

1 failed test on run #329 ↗ī¸Ž

1 8 0 1 Flakiness 0

Details:

Merge 48fc8bcb31d11eb7073eb96bae10eabae55f4cea into b9db03ab6e3c01248970c4606ef4...
Project: Irene Commit: 6ab16bd673 ℹī¸
Status: Failed Duration: 04:25 💡
Started: Jun 13, 2024 1:37 AM Ended: Jun 13, 2024 1:41 AM
Failed  cypress/tests/dynamic-scan.spec.ts â€ĸ 1 failed test View Output
Test Artifacts
Dynamic Scan > it tests dynamic scan for an apk file: 58062 Test Replay Screenshots

Review all test suite changes for PR #1400 ↗ī¸Ž

cypress[bot] commented 5 months ago

2 failed tests on run #338 ↗ī¸Ž

2 8 0 0 Flakiness 0

Details:

complete security analysis details page revamp
Project: Irene Commit: 25e421478d
Status: Failed Duration: 07:40 💡
Started: Jun 19, 2024 12:05 PM Ended: Jun 19, 2024 12:12 PM
Failed  dynamic-scan.spec.ts â€ĸ 1 failed test View Output
Test Artifacts
Dynamic Scan > it tests dynamic scan for an apk file: 58062 Test Replay Screenshots
Failed  auth.spec.ts â€ĸ 1 failed test View Output
Test Artifacts
User Login > should redirect authenticated user to dashboard after logging in Test Replay Screenshots

Review all test suite changes for PR #1400 ↗ī¸Ž

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
3.2% Duplication on New Code

See analysis details on SonarCloud