appknox / irene

I AM SHER LOCKED. Dashboard for Appknox Users.
https://secure.appknox.com
GNU Affero General Public License v3.0
20 stars 11 forks source link

DAST Automation P1 SAST Results Page UI #1403

Closed avzz-19 closed 5 months ago

coderabbitai[bot] commented 5 months ago

[!WARNING]

Rate limit exceeded

@avzz-19 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 27 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between c63e6a2070472cd9115a8669e1ae1e4b50f19f80 and b8bf0c9ff3732804cf2ee6595dcdb1e991a77eac.

Walkthrough

This update integrates a new feature in the application: the static scan functionality for file details. Enhancements include additions to routing, styling, Ember components, templates, tests, and translations. Key changes involve removing an deprecated property from AkButtonSignature, and modifying AkTabsSignature functionality. Moreover, a comprehensive static scan page layout and functionality have been implemented along with associated tests and internationalization updates.

Changes

File(s) Change Summary
app/components/ak-button/index.ts Removed the iconSize property from the AkButtonSignature interface.
app/components/ak-tabs/index.ts Removed the Args property from the AkTabsSignature interface.
app/components/file-details/static-scan/index.{hbs,scss,ts} Introduced comprehensive layout and functionality for static scan results display, including new components and styles.
app/router.ts Added a new route static-scan under the file route for static scan actions.
app/routes/authenticated/dashboard/file/static-scan.ts Introduced a new route AuthenticatedFileStaticScanRoute to fetch and return file records based on fileid parameter.
app/styles/_component-variables.scss Added new CSS variables for file-details-static-scan related styling.
app/styles/_icons.scss Added a new icon class .ak-icon-bug-report.
app/templates/authenticated/dashboard/file/static-scan.hbs Introduced a new template file for displaying SAST results and scan actions.
tests/integration/components/file-details/static-scan-test.js Added integration tests for file-details/static-scan component functionality including rendering and rescanning.
translations/en.json Added new translations related to SAST results and actions.
translations/ja.json Added new Japanese translations related to SAST results and actions.

Sequence Diagram

sequenceDiagram
    participant User
    participant Router
    participant StaticScanRoute
    participant FileDetailsStaticScan
    User->>Router: Navigate to /file/:id/static-scan
    Router->>StaticScanRoute: Fetch file data by ID
    StaticScanRoute->>FileDetailsStaticScan: Pass file data to component
    FileDetailsStaticScan->>User: Display static scan results
    User->>FileDetailsStaticScan: Initiate static scan rescan
    FileDetailsStaticScan->>RescanService: Trigger rescan
    RescanService->>FileDetailsStaticScan: Return scan results
    FileDetailsStaticScan->>User: Update and display new scan results

Poem

In the land of code, a change took flight,
For file scans now, a brand new light.
Static results, so clear and true,
Tabs and buttons with functions anew.
Tests and routes, all set to go,
Celebrating progress, onward we flow! 🚀


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cypress[bot] commented 5 months ago

5 failed tests on run #335 ↗ī¸Ž

5 4 0 1 Flakiness 0

Details:

Merge 2b1175f08a4798763d0d6dbd1fc9018736998747 into 89b5b168719f80ebcab0eea0de3d...
Project: Irene Commit: d8ac7ebeaa ℹī¸
Status: Failed Duration: 12:21 💡
Started: Jun 18, 2024 8:05 AM Ended: Jun 18, 2024 8:17 AM
Failed  upload-app.spec.ts â€ĸ 4 failed tests View Output
Test Artifacts
Upload App > It successfully uploads an apk file Test Replay Screenshots
Upload App > It successfully uploads an aab file Test Replay Screenshots
Upload App > It successfully uploads an ipa file Test Replay Screenshots
Upload App > It successfully uploads an apk file (via link) Test Replay Screenshots
Failed  dynamic-scan.spec.ts â€ĸ 1 failed test View Output
Test Artifacts
Dynamic Scan > it tests dynamic scan for an apk file: 58062 Test Replay Screenshots

Review all test suite changes for PR #1403 ↗ī¸Ž

cloudflare-workers-and-pages[bot] commented 5 months ago

Deploying irenestaging with  Cloudflare Pages  Cloudflare Pages

Latest commit: b8bf0c9
Status: âœ…  Deploy successful!
Preview URL: https://96bc547b.irenestaging.pages.dev
Branch Preview URL: https://pd-1332-dast-automation-p-1.irenestaging.pages.dev

View logs

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
13.1% Duplication on New Code

See analysis details on SonarCloud

cypress[bot] commented 5 months ago

1 failed test on run #362 ↗ī¸Ž

1 9 0 0 Flakiness 0

Details:

DAST Automation(P1) SAST page
Project: Irene Commit: b8bf0c9ff3
Status: Failed Duration: 07:25 💡
Started: Jul 2, 2024 7:12 PM Ended: Jul 2, 2024 7:19 PM
Failed  cypress/tests/dynamic-scan.spec.ts â€ĸ 1 failed test View Output
Test Artifacts
Dynamic Scan > it tests dynamic scan for an apk file: 58062 Test Replay Screenshots

Review all test suite changes for PR #1403 ↗ī¸Ž