appknox / irene

I AM SHER LOCKED. Dashboard for Appknox Users.
https://secure.appknox.com
GNU Affero General Public License v3.0
20 stars 11 forks source link

New Tabs Variant in AK Tabs #1404

Closed SmitGala closed 5 months ago

coderabbitai[bot] commented 5 months ago

[!WARNING]

Rate limit exceeded

@SmitGala has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 48 minutes and 29 seconds before requesting another review.

How to resolve this issue? After the wait time has elapsed, a review can be triggered using the `@coderabbitai review` command as a PR comment. Alternatively, push new commits to this PR. We recommend that you space out your commits to avoid hitting the rate limit.
How do rate limits work? CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our [FAQ](https://coderabbit.ai/docs/faq) for further information.
Commits Files that changed from the base of the PR and between 2f383bc95bf374218d363607644f5242e8af63b8 and d117a811ca82d1e87e8f9c552c5b4ca27f6ebc98.

Walkthrough

The update introduces a new indicatorVariant property to the ak-tabs component, enabling different visual styles for the active tab indicator ('line' or 'shadow'). Changes span across JavaScript, TypeScript, SCSS, and tests to integrate and verify the new feature, including class updates, style adjustments, and new interface properties.

Changes

Files/Paths Change Summary
app/components/ak-tabs/index.stories.js Added indicatorVariant property to commonArgs and Template to support the new indicator variant.
app/components/ak-tabs/item/index.scss Adjusted font weights for .active-line, and added styles for .active-shadow class.
app/components/ak-tabs/item/index.ts Introduced indicatorVariant in AkTabsItemSignature, added variant getter, and updated activeClass.
app/styles/_component-variables.scss Added new variable --ak-tabs-active-box-shadow.
tests/acceptance/security/nav-menu-test.js Updated CSS class check from _active_ to _active-line_ for specific menu items.
tests/integration/components/ak-tabs/index-test.js Changed CSS class name checked for an active tab from _active_ to _active-line_.
tests/integration/components/ak-tabs/item-test.js Updated CSS class name in assertion from ${styles['active']} to ${styles['active-line']}.

Sequence Diagram(s)

(Sequence diagrams not provided as the change is too straightforward for detailed flow visualization.)

Poem

In the land of tabs, a change so fine,
An indicator variant, shadow or a line.
With styles so sleek, and tests all anew,
The active tab’s elegance gracefully grew.
🐇✨ Tabs now shine with a new, lovely hue!


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cloudflare-workers-and-pages[bot] commented 5 months ago

Deploying irenestaging with  Cloudflare Pages  Cloudflare Pages

Latest commit: d117a81
Status: ✅  Deploy successful!
Preview URL: https://8c345bca.irenestaging.pages.dev
Branch Preview URL: https://pd-1334-new-tab-variant.irenestaging.pages.dev

View logs

cypress[bot] commented 5 months ago

Passing run #339 ↗︎

0 10 0 0 Flakiness 0

Details:

Merge 8836a2de0e974de810fd589831b9c58c3c989197 into 16de0fa86facdc4aa8c8e1a2aa10...
Project: Irene Commit: c0b68e9160 ℹ️
Status: Passed Duration: 04:15 💡
Started: Jun 20, 2024 9:01 AM Ended: Jun 20, 2024 9:05 AM

Review all test suite changes for PR #1404 ↗︎

sonarcloud[bot] commented 5 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud