Closed SmitGala closed 5 months ago
Latest commit: |
d117a81
|
Status: | ✅ Deploy successful! |
Preview URL: | https://8c345bca.irenestaging.pages.dev |
Branch Preview URL: | https://pd-1334-new-tab-variant.irenestaging.pages.dev |
0 | 10 | 0 | 0 | 0 |
Details:
Merge 8836a2de0e974de810fd589831b9c58c3c989197 into 16de0fa86facdc4aa8c8e1a2aa10... | |||
Project: Irene | Commit: c0b68e9160 ℹ️ |
||
Status: Passed | Duration: 04:15 💡 | ||
Started: Jun 20, 2024 9:01 AM | Ended: Jun 20, 2024 9:05 AM |
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Walkthrough
The update introduces a new
indicatorVariant
property to theak-tabs
component, enabling different visual styles for the active tab indicator ('line' or 'shadow'). Changes span across JavaScript, TypeScript, SCSS, and tests to integrate and verify the new feature, including class updates, style adjustments, and new interface properties.Changes
app/components/ak-tabs/index.stories.js
indicatorVariant
property tocommonArgs
andTemplate
to support the new indicator variant.app/components/ak-tabs/item/index.scss
.active-line
, and added styles for.active-shadow
class.app/components/ak-tabs/item/index.ts
indicatorVariant
inAkTabsItemSignature
, addedvariant
getter, and updatedactiveClass
.app/styles/_component-variables.scss
--ak-tabs-active-box-shadow
.tests/acceptance/security/nav-menu-test.js
_active_
to_active-line_
for specific menu items.tests/integration/components/ak-tabs/index-test.js
_active_
to_active-line_
.tests/integration/components/ak-tabs/item-test.js
${styles['active']}
to${styles['active-line']}
.Sequence Diagram(s)
(Sequence diagrams not provided as the change is too straightforward for detailed flow visualization.)
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share
- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)Tips
### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit