search

appknox / irene

I AM SHER LOCKED. Dashboard for Appknox Users.
https://secure.appknox.com
GNU Affero General Public License v3.0
20 stars 11 forks source link

Add support for specific devicefarm url for specific organization #1410

Closed krishnendu closed 4 months ago

krishnendu commented 5 months ago

Use organization devicefarm url if present instead of env

coderabbitai[bot] commented 5 months ago

Walkthrough

This update enhances the application's handling of the dashboard configuration by integrating the ConfigurationService throughout routes and services. Key changes include injecting this service into the ApplicationRoute, AuthenticatedRoute, and StatusRoute, allowing them to fetch and manage configuration data efficiently. Additionally, the access levels of certain types in network.ts have been modified, promoting better data encapsulation and accessibility.

Changes

File Change Summary
app/routes/application.ts Added getDashboardConfig() call within await all([]) block in ApplicationRoute class.
app/routes/authenticated.ts Injected ConfigurationService and updated model method to load dashboard config in AuthenticatedRoute class.
app/routes/status.ts Injected ConfigurationService and implemented beforeModel to fetch dashboard config in StatusRoute class.
app/services/configuration.ts Enhanced ConfigurationService to handle dashboard configuration, added new methods and properties, including dashboardData and getDashboardConfig().
app/services/devicefarm.ts Declared session service and updated devicefarmURL getter to use session auth and config data in DevicefarmService class.
app/services/network.ts Changed Header and RequestOptions types from private to public.
tests/acceptance/.../status-redirect-test.js Added network stubbing for acceptance tests, introduced mock device farm URL, and registered server routes for testing interactions.

Poem

In the meadow where code does play,
Configuration blooms in bright array,
Routes now dance with data so true,
Fetching insights, fresh as dew.
Devicefarm waits with a cheerful ping,
Oh, how sweet the changes bring!
🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cypress[bot] commented 5 months ago

1 failed test on run #351 ↗︎

1 9 0 0 Flakiness 0

Details:

Merge a26f9759e4a981885829fe4435ac4504b9efbdbe into 530d7d59f0526570ce5b7de86b50...
Project: Irene Commit: 0253495d84 ℹ️
Status: Failed Duration: 04:29 💡
Started: Jun 27, 2024 8:01 PM Ended: Jun 27, 2024 8:05 PM
Failed  cypress/tests/dynamic-scan.spec.ts • 1 failed test View Output
Test Artifacts
Dynamic Scan > it tests dynamic scan for an apk file: 58062 Test Replay Screenshots

Review all test suite changes for PR #1410 ↗︎

cloudflare-workers-and-pages[bot] commented 4 months ago

Deploying irenestaging with  Cloudflare Pages  Cloudflare Pages

Latest commit: e3dbb92
Status: ✅  Deploy successful!
Preview URL: https://474e70b7.irenestaging.pages.dev
Branch Preview URL: https://pd-1360.irenestaging.pages.dev

View logs

sonarcloud[bot] commented 4 months ago

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint