appknox / irene

I AM SHER LOCKED. Dashboard for Appknox Users.
https://secure.appknox.com
GNU Affero General Public License v3.0
20 stars 11 forks source link

Manual scan full page implementation #1413

Closed future-pirate-king closed 4 months ago

coderabbitai[bot] commented 5 months ago

Walkthrough

The recent changes introduce a comprehensive manual scan feature to an Ember application, adding new UI components, styling, and logic to handle manual file scans. This includes components for scan requests, progress status, results display, and various form sections (VPN details, login details, and additional comments). New routes and tests ensure the functionality is well-integrated and thoroughly checked.

Changes

File(s) Change Summary
app/components/file-details/manual-scan/index.hbs Introduced a manual scan UI component with various sections (breadcrumb, forms, tabs, etc.).
app/components/file-details/manual-scan/index.scss Defined styling rules for the manual scan UI component.
app/components/file-details/manual-scan/index.ts Added functionality for handling manual scans, including fetching and saving scan data, managing VPN details, etc.
app/components/file-details/manual-scan/progress-status/{index.hbs,index.scss,index.ts} Introduced a component for displaying manual scan progress status, including logic and styling.
app/components/file-details/manual-scan/request-access/{index.hbs,index.scss,index.ts} Introduced a component for requesting manual scan access, with UI and request handling logic.
app/components/file-details/manual-scan/request-form/{index.hbs,index.scss,index.ts} Added a dynamic form generation component for manual scan requests, supporting various form sections.
app/components/file-details/manual-scan/request-form/login-details/{index.hbs,index.scss,index.ts} Introduced a form for login details, including user role management, with UI and logic.
app/components/file-details/manual-scan/request-form/vpn-details/{index.hbs,index.scss,index.ts} Added a form for VPN details input, including status handling logic.
app/components/file-details/manual-scan/results/{index.hbs,index.scss,index.ts} Introduced a tabbed interface for displaying manual scan results with detailed vulnerability analysis.
app/components/file-details/manual-scan/request-form/additional-comments/{index.hbs,index.ts} Introduced a form component for adding additional comments within a modal for manual scanning.
app/components/file-details/manual-scan/request-form/basic-info/{index.hbs,index.scss,index.ts} Added a form layout for capturing basic information with UI and logic handling.
app/components/file-details/manual-scan/request-form/login-details/user-role-action/{index.hbs,index.ts} Introduced a component for handling user role actions within login details form.
app/models/file.ts Added a computed property manualVulnerabilityCount to the FileModel class.
app/router.ts Added a new route manual-scan under the file route.
app/routes/authenticated/dashboard/file/manual-scan.ts Introduced a route class for fetching file records based on fileid parameter.
tests/acceptance/file-details/manual-scan-test.js Introduced acceptance tests for manual scanning functionality, ensuring proper rendering and request handling.

Sequence Diagrams

Manual Scan Request Flow

sequenceDiagram
    participant User
    participant UI as Manual Scan UI
    participant Component as FileDetailsManualScanComponent
    participant Service as ManualScanService

    User->>UI: Open Manual Scan Tab
    UI->>Component: Initialize
    Component->>Service: Fetch Manual Scan Data
    Service-->>Component: Return Data
    Component-->>UI: Render Scan Form

    User->>UI: Fill and Submit Form
    UI->>Component: Handle Form Submit
    Component->>Service: Save Manual Scan Data
    Service-->>Component: Return Save Status
    Component-->>UI: Display Save Confirmation

Manual Scan Progress Status

sequenceDiagram
    participant User
    participant UI as Manual Scan UI
    participant Component as FileDetailsManualScanProgressStatusComponent
    participant Service as ManualScanService

    User->>UI: View Scan Progress
    UI->>Component: Initialize
    Component->>Service: Fetch Scan Progress
    Service-->>Component: Return Progress Data
    Component-->>UI: Render Progress Status

Poem

In the land of Ember bright, Manual scans now take flight. With forms and tabs, all in line, Vulnerabilities you'll define. Progress status, VPN in view, We celebrate this feature new! 🐰✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cloudflare-workers-and-pages[bot] commented 5 months ago

Deploying irenestaging with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1a57a73
Status: âœ…  Deploy successful!
Preview URL: https://a9dd4bb8.irenestaging.pages.dev
Branch Preview URL: https://pd-1336-manual-scan-page.irenestaging.pages.dev

View logs

cypress[bot] commented 4 months ago

Passing run #365 ↗ī¸Ž

0 10 0 0 Flakiness 0

Details:

Merge b6e1466d094a561632a56b2d31e17904887b40b6 into aca4472aa2de73172a5deb4d8547...
Project: Irene Commit: 89d35bb138 ℹī¸
Status: Passed Duration: 07:24 💡
Started: Jul 8, 2024 6:34 AM Ended: Jul 8, 2024 6:41 AM

Review all test suite changes for PR #1413 ↗ī¸Ž

sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
16 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
29.2% Duplication on New Code

See analysis details on SonarCloud

cypress[bot] commented 4 months ago

1 failed test on run #368 ↗ī¸Ž

1 9 0 0 Flakiness 0

Details:

manual scan full page implementation
Project: Irene Commit: 1a57a734eb
Status: Failed Duration: 05:59 💡
Started: Jul 10, 2024 10:25 AM Ended: Jul 10, 2024 10:31 AM
Failed  cypress/tests/dynamic-scan.spec.ts â€ĸ 1 failed test View Output
Test Artifacts
Dynamic Scan > it tests dynamic scan for an apk file: 58062 Test Replay Screenshots

Review all test suite changes for PR #1413 ↗ī¸Ž