Dast Automation(P1) - Final PR Changes

[coderabbitai[bot]]

[!IMPORTANT]

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

65 files out of 148 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The changes involve a significant refactor of the dynamic scan component, transitioning from a modal interface to a drawer interface. This includes updates to the layout, renaming of components and classes, and adjustments to styles for improved visual presentation. The modifications also encompass routing changes and enhancements to the dynamic scan functionality, ensuring a more intuitive user experience across the application.

Changes

File Path	Change Summary
app/components/dynamic-scan/drawer/index.hbs	Refactored modal to drawer component, updated header and body structure, and adjusted button placements.
app/components/dynamic-scan/drawer/index.scss	Removed .dynamic-scan-modal-body, renamed .dynamic-scan-modal-alert to .dynamic-scan-drawer-alert, and added .dynamic-scan-modal-cta for styling.
app/components/dynamic-scan/drawer/index.ts	Renamed DynamicScanModalSignature to DynamicScanDrawerSignature and updated component class names accordingly.
app/components/dynamic-scan/expiry/index.hbs	Removed the dynamic scan expiry component's UI, including countdown timer and interactive elements.
app/components/dynamic-scan/index.hbs	Updated to render <DynamicScan::Drawer> instead of <DynamicScan::Modal>.
app/components/file-details/dynamic-scan/action/index.hbs	Adjusted rendering logic for dynamic scan buttons based on file status and introduced a new component conditionally.
app/components/file-details/dynamic-scan/manual/index.ts	Transitioned from dynamicScan to file property for status checks, updating computed properties accordingly.
app/models/file.ts	Added a new getter method isReadyOrRunning to check dynamic status.
app/router.ts	Removed the 'automated' sub-route from the dynamic-scan route, simplifying the routing structure.
app/styles/_component-variables.scss	Removed outdated CSS variables and reorganized remaining variables for clarity.
app/styles/_icons.scss	Introduced a new icon class .ak-icon-stop-circle.
tests/acceptance/file-details/dynamic-scan-test.js	Added tests for the manual dynamic scan page, verifying UI elements and expiry functionality.
tests/integration/components/dynamic-scan-test.js	Removed integration tests for the dynamic scan component.

Possibly related PRs

• #1456: The changes in this PR involve modifications to the DynamicScanActions class and enhancements to test assertions related to dynamic scanning, which are directly relevant to the refactoring of the dynamic scan component in the main PR.

Suggested reviewers

• future-pirate-king
• avzz-19

Poem

In lines of code, we find our way,
Enhancing routes, come what may.
With drawers opened wide and bright,
The UI shines, a pure delight.
Code Rabbit hops with joy and cheer,
For better views are truly here!
🐰✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[cloudflare-workers-and-pages[bot]]

Deploying irenestaging with    Cloudflare Pages

Latest commit:	a4a4b13
Status:	✅  Deploy successful!
Preview URL:	https://3f1a1013.irenestaging.pages.dev
Branch Preview URL:	https://pd-1375-dast-automation-p1.irenestaging.pages.dev

View logs

[cypress[bot]]

5 failed tests on run #364 ↗︎

5

4

0

1

0

Details:

Merge 1f384e9f3adf866531ff5bad90bd5b505b8fc909 into 9fcb5afcac7538858af451a96f11...
Project: Irene	Commit: 62ac980e93 ℹ️
Status: Failed	Duration: 12:16 💡
Started: Jul 3, 2024 9:05 AM	Ended: Jul 3, 2024 9:17 AM

  dynamic-scan.spec.ts • 1 failed test

View Output

Test		Artifacts
Dynamic Scan > it tests dynamic scan for an apk file: 58062		Test Replay Screenshots

  upload-app.spec.ts • 4 failed tests

View Output

Test		Artifacts
Upload App > It successfully uploads an apk file		Test Replay Screenshots
Upload App > It successfully uploads an aab file		Test Replay Screenshots
Upload App > It successfully uploads an ipa file		Test Replay Screenshots
Upload App > It successfully uploads an apk file (via link)		Test Replay Screenshots

Review all test suite changes for PR #1417 ↗︎

[sonarcloud[bot]]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[cypress[bot]]

Irene    Run #486

Run Properties:   Failed #486  •  7063e26c34: fix failing e2e tests

Project	Irene
Run status	Failed #486
Run duration	12m 23s
Commit	7063e26c34: fix failing e2e tests
Committer	yibaebi
View all properties for this run ↗︎

---

Test results
Failures	2
Flaky	0
Pending	0
Skipped	0
Passing	20

---

Tests for review

  cypress/tests/dynamic-scan.spec.ts • 2 failed tests

View Output

Test		Artifacts
Dynamic Scan > it tests dynamic scan for an apk file: 58062		Test Replay Screenshots
Dynamic Scan > it tests dynamic scan for an ipa file: 58061		Test Replay Screenshots

[sonarcloud[bot]]

Quality Gate passed

Issues
20 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
18.0% Duplication on New Code

See analysis details on SonarCloud