appknox / irene

I AM SHER LOCKED. Dashboard for Appknox Users.
https://secure.appknox.com
GNU Affero General Public License v3.0
20 stars 11 forks source link

Upload app e2e test updates #1418

Closed Yibaebi closed 4 months ago

coderabbitai[bot] commented 4 months ago

Walkthrough

The updates predominantly focus on enhancing the components and user interface of the file details and project settings within the application. Changes include nesting components, adding new attributes for alignment and spacing, and updates to route bindings. Additionally, new routes for scan actions and modifications to styling elements were made to improve visual consistency and functionality.

Changes

File(s) Change Summary
app/components/file-chart/index.hbs Adjusted layout properties of <AkStack> component for alignment and spacing.
app/components/file-details/index.hbs Nested AkStack within AkBreadcrumbs::Container; replaced old summary and scan action components.
app/components/file-details/scan-actions/api-scan/index.hbs Added @route attribute and @model binding for navigation with file ID.
app/components/file-details/scan-actions/dynamic-scan/index.hbs Added new route attribute, model binding, and a data-test attribute.
app/components/file-details/scan-actions/index.scss Updated scan-status-card class with new width and flex properties.
app/components/file-details/scan-actions/manual-scan/index.hbs Added route and model binding for manual scan view details.
app/components/file-details/scan-actions/static-scan/index.hbs Added data-test-cy, @route, and @model attributes.
app/components/file-details/severity-level/index.hbs Simplified AkStack component attribute settings.
app/components/file-details/skeleton-loader/index.hbs Added new attributes, reorganized structure, and adjusted layout of AkStack and AkDivider elements.
app/components/file-details/skeleton-loader/index.scss Introduced new CSS classes .file-details-skeleton-container and .scan-actions-status-card.
app/components/project-settings/general-settings/.../index.hbs Conditional rendering based on @featureAvailable; reorganized structure and updated components.
app/components/project-settings/general-settings/.../index.ts Added featureAvailable property to the interface and new getter method.
app/router.ts Added new routes for manual-scan and dynamic-scan.
app/styles/_component-variables.scss Modified and added various color and layout variables.
app/templates/authenticated/dashboard/file/index-loading.hbs Changed class selector from w-9/12 to a generic div tag.
app/templates/authenticated/dashboard/file/index.hbs Removed VncViewer component with @profileId parameter usage.
cypress/support/Actions/common/UploadAppActions.ts Updated text element identifier from 'staticScan' to 'sast' in a Cypress test.
tests/acceptance/file-details-test.js Added tests for navigating to specific scan pages based on actions in the file details view.

Poem

In the code where bytes align, New routes and components now do shine. With nested stacks and colors bright, User interfaces delight. Bugs are scanned, features sprout, Enhancements made throughout. Celebrate this change so vast, Our code evolves, steadfast. 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
sonarcloud[bot] commented 4 months ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cloudflare-workers-and-pages[bot] commented 4 months ago

Deploying irenestaging with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4ace202
Status: âœ…  Deploy successful!
Preview URL: https://8e76b274.irenestaging.pages.dev
Branch Preview URL: https://pd-1375-dast-automation-p1.irenestaging.pages.dev

View logs

cypress[bot] commented 4 months ago

1 failed test on run #366 ↗ī¸Ž

1 8 0 1 Flakiness 0

Details:

Merge 4ace202be63e08188e0cfc81c0ff693a2cba0366 into aca4472aa2de73172a5deb4d8547...
Project: Irene Commit: e33b863ffe ℹī¸
Status: Failed Duration: 04:15 💡
Started: Jul 10, 2024 8:31 AM Ended: Jul 10, 2024 8:36 AM
Failed  cypress/tests/dynamic-scan.spec.ts â€ĸ 1 failed test View Output
Test Artifacts
Dynamic Scan > it tests dynamic scan for an apk file: 58062 Test Replay Screenshots

Review all test suite changes for PR #1418 ↗ī¸Ž