appknox / irene

I AM SHER LOCKED. Dashboard for Appknox Users.
https://secure.appknox.com
GNU Affero General Public License v3.0
20 stars 11 forks source link

file active status check to disable button #1426

Closed avzz-19 closed 3 months ago

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes enhance the user interface by dynamically disabling buttons and input fields based on the state of the file object. Key updates include the implementation of @disabled property bindings across various components, ensuring that actions are only enabled when files are active. This enhancement prevents accidental submissions, refines control flow in both manual and static scan functionalities, and ultimately elevates the user experience.

Changes

Files Change Summary
app/components/file-details/manual-scan/*, app/components/file-details/manual-scan/request-form/* Added @disabled={{not @file.isActive}} to multiple components, disabling interactions when the file is inactive.
app/components/file-details/static-scan/* Updated button disabling logic from @file.isStaticCompleted to a new computed property isRescanDisabled, based on multiple conditions.
app/components/file-details/api-scan/captured-apis/* Introduced @disabled={{not @file.isActive}} to buttons and toggles, enhancing control based on file activity.
tests/acceptance/file-details/manual-scan-test.js, tests/integration/components/file-details/static-scan-test.js Added tests to verify that buttons and inputs are disabled for inactive files, improving coverage and functionality.

Poem

🐰 In a world of files, both static and fleet,
A button now waits, with a hop and a beat.
When the file's inactive, it won't hop and dash,
Preventing lost moments, a wise little flash!
So here’s to our changes, with joy let us sing,
A smoother experience, oh what joy they bring! 🌼✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cypress[bot] commented 3 months ago



Test summary

3 6 0 1


Run details

Project Irene
Status Failed
Commit 25cb0ab62b ℹ️
Started Aug 5, 2024 10:15 AM
Ended Aug 5, 2024 10:17 AM
Duration 01:53 πŸ’‘
OS Linux Debian -
Browser Chrome 123

View run in Cypress Cloud ➑️


Failures

upload-app.spec.ts Failed
1 Upload App > It successfully uploads an apk file
2 Upload App > It successfully uploads an aab file
3 Upload App > It successfully uploads an ipa file
4 Upload App > It successfully uploads an apk file (via link)
5 Upload App > App upload fails if org plan has insufficient upload credits
dynamic-scan.spec.ts Failed
1 Dynamic Scan > it tests dynamic scan for an apk file: 58062

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

cloudflare-workers-and-pages[bot] commented 3 months ago

Deploying irenestaging with  Cloudflare Pages  Cloudflare Pages

Latest commit: 2125d1a
Status: βœ…  Deploy successful!
Preview URL: https://465c6a82.irenestaging.pages.dev
Branch Preview URL: https://file-inactive-check-disabled.irenestaging.pages.dev

View logs

sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
23.0% Duplication on New Code

See analysis details on SonarCloud