Closed SmitGala closed 3 months ago
Latest commit: |
3641060
|
Status: | â Deploy successful! |
Preview URL: | https://4571ee61.irenestaging.pages.dev |
Branch Preview URL: | https://marketplace-page-refactor-re.irenestaging.pages.dev |
Passed #430
•
9bbe15e7d7 âšī¸: Merge 7731524fdd95279fb5b8e6319cc8d130f91ff16b into 2b8d700483bb4de2a559e239c403...
Project |
Irene
|
Branch Review |
marketplace-page-refactor-remove-global-style-css
|
Run status |
Passed #430
|
Run duration | 04m 51s |
Commit |
9bbe15e7d7 âšī¸: Merge 7731524fdd95279fb5b8e6319cc8d130f91ff16b into 2b8d700483bb4de2a559e239c403...
|
Committer | SmitGala |
View all properties for this run âī¸ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
10
|
View all changes introduced in this branch âī¸ |
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code
Failed #434
•
41d3232d35: Merge pull request #1445 from appknox/marketplace-page-refactor-remove-global-st...
Project |
Irene
|
Branch Review |
master
|
Run status |
Failed #434
|
Run duration | 09m 34s |
Commit |
41d3232d35: Merge pull request #1445 from appknox/marketplace-page-refactor-remove-global-st...
|
Committer | Sam David |
View all properties for this run âī¸ |
Test results | |
---|---|
Failures |
1
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
9
|
View all changes introduced in this branch âī¸ |
View
Output
Test | Artifacts | |
---|---|---|
Upload App > It successfully uploads an ipa file |
Test Replay
Screenshots
|
Walkthrough
The changes involve significant updates to the marketplace component, transitioning from standard HTML elements to custom components from the Ak library. This includes enhancements to the semantic structure and styling consistency. New CSS classes and variables have been introduced for improved layout and presentation, while existing styles have been updated to utilize CSS variables for better maintainability, reflecting a shift toward a more modular design.
Changes
app/components/marketplace/card-content/...
<div>
to<AkTypography>
with a new font weight property; new CSS class.marketplace-card-title
added.app/components/marketplace/index.hbs
<AkTypography>
components; layout improved with<AkStack>
.app/components/marketplace/index.scss
.marketplace-header
,.sub-header
, and.sub-header-description
added.app/components/marketplace/integration-card/...
app/components/marketplace/integration-list/...
vertical-align-center
class from outer<div>
, affecting vertical alignment.app/components/marketplace/plugin-card/...
<div>
to<AkTypography>
with new properties for alignment and font weight.app/components/marketplace/plugin-list/...
vertical-align-center
class; layout enhanced with flex properties in the.marketplace-list
class.app/styles/_component-variables.scss
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share
- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)Tips
### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit