appknox / irene

I AM SHER LOCKED. Dashboard for Appknox Users.
https://secure.appknox.com
GNU Affero General Public License v3.0
20 stars 11 forks source link

Marketplace - Remove Global Style CSS #1445

Closed SmitGala closed 3 months ago

coderabbitai[bot] commented 3 months ago

Walkthrough

The changes involve significant updates to the marketplace component, transitioning from standard HTML elements to custom components from the Ak library. This includes enhancements to the semantic structure and styling consistency. New CSS classes and variables have been introduced for improved layout and presentation, while existing styles have been updated to utilize CSS variables for better maintainability, reflecting a shift toward a more modular design.

Changes

Files Change Summary
app/components/marketplace/card-content/... Title rendering changed from <div> to <AkTypography> with a new font weight property; new CSS class .marketplace-card-title added.
app/components/marketplace/index.hbs Standard HTML elements replaced with <AkTypography> components; layout improved with <AkStack>.
app/components/marketplace/index.scss New styles for headers with classes .marketplace-header, .sub-header, and .sub-header-description added.
app/components/marketplace/integration-card/... Hardcoded colors replaced with CSS variables for border and text colors.
app/components/marketplace/integration-list/... Removed vertical-align-center class from outer <div>, affecting vertical alignment.
app/components/marketplace/plugin-card/... Title changed from <div> to <AkTypography> with new properties for alignment and font weight.
app/components/marketplace/plugin-list/... Removed vertical-align-center class; layout enhanced with flex properties in the .marketplace-list class.
app/styles/_component-variables.scss New CSS custom properties for marketplace elements introduced to enhance theming and styling consistency.

Poem

In the marketplace, oh what a sight,
With Ak components shining bright! 🌟
Titles now dance with style and grace,
Flex and stack, they find their place.
Rabbits rejoice, for changes abound,
A cozy new look, all around! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cloudflare-workers-and-pages[bot] commented 3 months ago

Deploying irenestaging with  Cloudflare Pages  Cloudflare Pages

Latest commit: 3641060
Status: âœ…  Deploy successful!
Preview URL: https://4571ee61.irenestaging.pages.dev
Branch Preview URL: https://marketplace-page-refactor-re.irenestaging.pages.dev

View logs

cypress[bot] commented 3 months ago

Irene    Run #430

Run Properties:  status check passed Passed #430  •  git commit 9bbe15e7d7 ℹī¸: Merge 7731524fdd95279fb5b8e6319cc8d130f91ff16b into 2b8d700483bb4de2a559e239c403...
Project Irene
Branch Review marketplace-page-refactor-remove-global-style-css
Run status status check passed Passed #430
Run duration 04m 51s
Commit git commit 9bbe15e7d7 ℹī¸: Merge 7731524fdd95279fb5b8e6319cc8d130f91ff16b into 2b8d700483bb4de2a559e239c403...
Committer SmitGala
View all properties for this run ↗ī¸Ž

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 10
View all changes introduced in this branch ↗ī¸Ž
sonarcloud[bot] commented 3 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

cypress[bot] commented 3 months ago

Irene    Run #434

Run Properties:  status check failed Failed #434  •  git commit 41d3232d35: Merge pull request #1445 from appknox/marketplace-page-refactor-remove-global-st...
Project Irene
Branch Review master
Run status status check failed Failed #434
Run duration 09m 34s
Commit git commit 41d3232d35: Merge pull request #1445 from appknox/marketplace-page-refactor-remove-global-st...
Committer Sam David
View all properties for this run ↗ī¸Ž

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 9
View all changes introduced in this branch ↗ī¸Ž


Tests for review

Failed  cypress/tests/upload-app.spec.ts â€ĸ 1 failed test View Output
Test Artifacts
Upload App > It successfully uploads an ipa file Test Replay Screenshots