appknox / irene

I AM SHER LOCKED. Dashboard for Appknox Users.
https://secure.appknox.com
GNU Affero General Public License v3.0
20 stars 11 forks source link

global styles migration in partner dashboard #1450

Closed Yibaebi closed 2 months ago

coderabbitai[bot] commented 2 months ago

Walkthrough

The pull request introduces a series of modifications across multiple components in the application. Key changes include the replacement of standard HTML elements with specialized components from the Ak component library, such as AkButton, AkTypography, and AkLink. Class names have been updated for consistency and readability, and several CSS classes have been removed or added to streamline styling. The overall structure of the components remains intact, with a focus on enhancing semantic markup and improving maintainability.

Changes

File Path Change Summary
app/components/partner/client-info/template.hbs Replaced <em> with AkTypography, updated link to AkLink, and added AkButton with AkIcon.
app/components/partner/client-list/index.hbs Changed class attributes for padding from padding-h-1 padding-b-2 to pb-4 px-2.
app/components/partner/client-plan/template.hbs Updated class names for <strong> elements for scans and projects from margin-r-h to mr-1.
app/components/partner/client-project-detail/index.hbs Replaced AkIcon with AppPlatformIcon and updated package name display to AkTypography.
app/components/partner/client-project-list/index.hbs Replaced <div> with AkStack and <AkTypography> for headers, improving layout and styling.
app/components/partner/client-project-list/index.scss Added new .badge class for styling badge elements.
app/components/partner/client-project-list/item/index.hbs Replaced <AkIcon> with <AppPlatformIcon> and updated date display to AkTypography.
app/components/partner/client-project-list/item/index.scss Removed .platform-android and .platform-apple, added .view-files-button.
app/components/partner/client-report-download/index.hbs Replaced standard buttons with AkButton and AkIconButton, improved layout for progress display.
app/components/partner/client-report-download/index.scss Updated .button-progress class and added .is-progress for animation.
app/components/partner/client-report-download/report-password/index.hbs Replaced standard buttons with AkIconButton and AkButton, improved structure for icons and text.
app/components/partner/client-uploads-list/index.hbs Updated structure with AkTypography components for improved styling.
app/components/partner/client-uploads-list/index.scss Removed .title and .app-name, added .badge.
app/components/partner/credit-transfer/index.hbs Transitioned to AkButton for transfer button, improved structure with AkTypography.
app/components/partner/credit-transfer/index.scss Removed .disabled-btn class.
app/templates/authenticated/partner/analytics.hbs Updated padding classes for improved readability.
app/templates/authenticated/partner/client.hbs Updated padding classes for improved readability.
tests/integration/components/partner/client-project-list-test.js Modified assertions for table headers to match new structure.
tests/integration/components/partner/client-uploads-list/component-test.js Updated selectors in assertions for accuracy.

Possibly related PRs

Poem

🐰 In the land of code where rabbits play,
Components sprout in a stylish way.
AkButtons hop, and Typography sings,
A garden of changes, oh, what joy it brings!
With every update, the UI shines bright,
Hopping along, everything feels just right! đŸŒŧ


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying irenestaging with  Cloudflare Pages  Cloudflare Pages

Latest commit: bc819a1
Status: âœ…  Deploy successful!
Preview URL: https://760799e0.irenestaging.pages.dev
Branch Preview URL: https://pd-1430-partner-dashboard-st.irenestaging.pages.dev

View logs

cypress[bot] commented 2 months ago

Irene    Run #447

Run Properties:  status check passed Passed #447  •  git commit 3216b84a47 ℹī¸: Merge 37f0637a48a20f93f58eeb011accc78a93f0792d into 5064f9f9fada86090e78415f2b07...
Project Irene
Branch Review PD-1430-partner-dashboard-styles-refactor
Run status status check passed Passed #447
Run duration 05m 55s
Commit git commit 3216b84a47 ℹī¸: Merge 37f0637a48a20f93f58eeb011accc78a93f0792d into 5064f9f9fada86090e78415f2b07...
Committer Yibaebi Elliot
View all properties for this run ↗ī¸Ž

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 10
View all changes introduced in this branch ↗ī¸Ž
sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
20.5% Duplication on New Code

See analysis details on SonarCloud