appknox / irene

I AM SHER LOCKED. Dashboard for Appknox Users.
https://secure.appknox.com
GNU Affero General Public License v3.0
20 stars 11 forks source link

page not found refactor #1462

Closed future-pirate-king closed 2 months ago

coderabbitai[bot] commented 2 months ago

Walkthrough

A new "Page Not Found" component has been created, consisting of an index.hbs, index.scss, and index.ts file, along with updates to _component-variables.scss and not-found.hbs. The component features a structured layout for displaying a 404 error message, complete with styling and custom properties for visual consistency. The existing not-found.hbs template has been simplified to utilize the new component, enhancing modularity and maintainability.

Changes

File(s) Change Summary
app/components/page-not-found/index.hbs Introduced a new page-not-found component with a structured layout using nested AkStack components.
app/components/page-not-found/index.scss Added styles for the page-not-found component, defining card styles and container properties.
app/components/page-not-found/index.ts Created PageNotFoundComponent, extending the base Component class, and added module declaration.
app/styles/_component-variables.scss Introduced new CSS custom properties for the page-not-found component's styling.
app/templates/not-found.hbs Simplified the template to use the new <PageNotFound /> component, removing explicit HTML structure.
app/components/ak-link/index.hbs Added a new parameter @replace to the ak-link component invocation.
app/components/ak-link/index.ts Added an optional property replace of type boolean to the AkLinkSignatureArgs interface.

Poem

🐰 In the land of lost and found,
A new page greets with joy profound.
With styles and stacks, it takes its stand,
A cozy home for errors, oh so grand!
Hop along, dear user, don’t you frown,
For the rabbit's here to guide you down! 🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

:heart: Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
:placard: Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cypress[bot] commented 2 months ago

Irene    Run #479

Run Properties:  status check failed Failed #479  •  git commit 180cc01299 ℹ️: Merge c9ceddd962da4bd1e2ee18d05547364fea2de80e into 8bbb40d2beebd7516cbe8984fa05...
Project Irene
Branch Review page-not-found-fix
Run status status check failed Failed #479
Run duration 15m 16s
Commit git commit 180cc01299 ℹ️: Merge c9ceddd962da4bd1e2ee18d05547364fea2de80e into 8bbb40d2beebd7516cbe8984fa05...
Committer Sam David
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 21
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎


Tests for review

cloudflare-workers-and-pages[bot] commented 2 months ago

Deploying irenestaging with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1bf9584
Status: ✅  Deploy successful!
Preview URL: https://b8fd802a.irenestaging.pages.dev
Branch Preview URL: https://page-not-found-fix.irenestaging.pages.dev

View logs

sonarcloud[bot] commented 2 months ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud