appknox / irene

I AM SHER LOCKED. Dashboard for Appknox Users.
https://secure.appknox.com
GNU Affero General Public License v3.0
20 stars 11 forks source link

fix deprecations in analytics, billing & account-settings #1481

Closed future-pirate-king closed 3 weeks ago

coderabbitai[bot] commented 1 month ago

Walkthrough

This pull request introduces several changes across multiple components in the application. Key modifications include the adjustment of methods for handling personal tokens and multi-factor authentication, the addition of a new registry entry for a date picker component, and updates to subscription handling in the organization billing component. Additionally, there are changes to the template rendering of tables, affecting their styling. The overall structure and functionality of the components remain intact, with no significant alterations to exported or public entities.

Changes

File Path Change Summary
app/components/account-settings/developer-settings/personal-token-list/index.ts Modified personalTokenList getter to use slice() instead of toArray().
app/components/account-settings/security/multi-factor-auth/index.ts Replaced findBy with find in computed properties (isMFAEnabled, isEmailMFAEnabled, isAppMFAEnabled) for clarity in condition checking.
app/components/ak-date-picker/calendar-nav/index.ts Added a new export declaration for AkDatePickerCalendarNavComponent in the registry.
app/components/ak-date-picker/index.hbs Simplified instantiation of CalendarComponent and updated @navComponent property for dynamic resolution.
app/components/organization-billing/index.ts Added subscriptionList getter; updated subscription, subscriptionCount, and sortedPlans getters for better state management.
app/components/organization-billing/invoice-list/index.hbs Updated @variant attribute of AkTable from 'bordered' to 'full-bordered'.
app/components/organization-billing/subscription/index.hbs Changed @variant attribute of AkTable from 'bordered' to 'full-bordered' within a conditional block.
app/models/analytics/recent-issue.ts Updated vulnerability property to use AsyncBelongsTo type, indicating an asynchronous relationship.

Possibly related PRs

Suggested reviewers

Poem

🐰 In the garden of code, we hop and play,
With tokens and tables, we brighten the day.
From toArray to slice, our changes are neat,
In the world of Ember, our work is a treat!
So let’s celebrate, with a joyful cheer,
For each little change brings us closer, my dear! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cloudflare-workers-and-pages[bot] commented 1 month ago

Deploying irenestaging with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7bba24d
Status: ✅  Deploy successful!
Preview URL: https://310fb04c.irenestaging.pages.dev
Branch Preview URL: https://pd-1559-fix-deprecation-anal.irenestaging.pages.dev

View logs

cypress[bot] commented 1 month ago

Irene    Run #513

Run Properties:  status check failed Failed #513  •  git commit 11c7dc21f6 ℹ️: Merge c4a50044b833bc972bff15214244496839042596 into 87fc4bb38f54580b73a226ccf1ae...
Project Irene
Branch Review PD-1559-fix-deprecation-analytics-billing-ac-settings
Run status status check failed Failed #513
Run duration 13m 32s
Commit git commit 11c7dc21f6 ℹ️: Merge c4a50044b833bc972bff15214244496839042596 into 87fc4bb38f54580b73a226ccf1ae...
Committer Sam David
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 31
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎


Tests for review

sonarcloud[bot] commented 3 weeks ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud