appknox / irene

I AM SHER LOCKED. Dashboard for Appknox Users.
https://secure.appknox.com
GNU Affero General Public License v3.0
20 stars 11 forks source link

add html formatting support in request response findings #1484

Open avzz-19 opened 3 weeks ago

coderabbitai[bot] commented 3 weeks ago

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request introduces modifications to enhance the handling of formatted text in the FileDetailsVulnerabilityAnalysisDetailsFindingsVulnerableApiComponent class. Key changes include the addition of an optional isHTML property in the FormattedResult interface and improvements to the getFormattedText method for detecting HTML content. A new method, getWhiteSpaceStyle, is introduced to determine white space styles based on content type. Additionally, a new function, formatHtmlResponseBody, is added to manage HTML response formatting in the parse-vulnerable-api-finding.ts file, alongside updates to test cases to validate these changes.

Changes

File Path Change Summary
app/components/file-details/vulnerability-analysis-details/findings/vulnerable-api/index.ts - Added optional isHTML property to FormattedResult interface.
- Updated getFormattedText method to check for HTML content.
- Introduced getWhiteSpaceStyle method for determining white space styles.
app/utils/parse-vulnerable-api-finding.ts - Added formatHtmlResponseBody function for formatting HTML response bodies.
- Enhanced handleBodyField function to robustly check for HTML content.
- Updated parseVulnerableApiFindingBlock and parseLine functions for better parsing logic.
tests/unit/utils/parse-vulnerable-api-finding-test.js - Modified test cases for parseVulnerableApiFinding and isVulnerableApiFinding functions to refine expected outputs and improve validation of parsing logic.

Possibly related PRs

Suggested reviewers

Poem

🐇 In the code where bunnies play,
New properties hop in to stay.
HTML or JSON, we now can see,
With whitespace styles, oh so free!
Parsing finds its joyful tune,
Thanks to changes made this noon! 🌼


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
cloudflare-workers-and-pages[bot] commented 3 weeks ago

Deploying irenestaging with  Cloudflare Pages  Cloudflare Pages

Latest commit: ce866c9
Status: ✅  Deploy successful!
Preview URL: https://1920af34.irenestaging.pages.dev
Branch Preview URL: https://add-html-formatting-support.irenestaging.pages.dev

View logs

cypress[bot] commented 3 weeks ago

Irene    Run #517

Run Properties:  status check failed Failed #517  •  git commit ecb544e701 ℹ️: Merge ce5b8c196dcff3b790702f34ed5d7590c121509b into 11c3dbc41c5e19e0d2b82f989239...
Project Irene
Branch Review add-html-formatting-support-in-findings
Run status status check failed Failed #517
Run duration 05m 49s
Commit git commit ecb544e701 ℹ️: Merge ce5b8c196dcff3b790702f34ed5d7590c121509b into 11c3dbc41c5e19e0d2b82f989239...
Committer Avi Shah
View all properties for this run ↗︎

Test results
Tests that failed  Failures 1
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 1
Tests that passed  Passing 30
View all changes introduced in this branch ↗︎


Tests for review

Failed  cypress/tests/dynamic-scan.spec.ts • 1 failed test View Output
Test Artifacts
Dynamic Scan > it tests dynamic scan for an apk file: 58062 Test Replay Screenshots
sonarcloud[bot] commented 2 weeks ago

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
14.3% Duplication on New Code

See analysis details on SonarQube Cloud