fix deprecation warnings in partner routes

coderabbitai[bot] commented 2 weeks ago

Walkthrough

The pull request introduces several modifications across various components, primarily focusing on how lists and data are retrieved and processed. Notable changes include the addition of a new menu item in the side navigation for the partner dashboard, adjustments from toArray() to slice() in multiple getters to enhance data handling, and updates to error handling mechanisms in certain tasks. The overall structure and logic of the components remain intact, ensuring existing functionalities are preserved while enhancing data management and user feedback.

Changes

File Path	Change Summary
app/components/home-page/organization-dashboard/side-nav/index.ts	Added a new menu item for the partner dashboard in `menuItems` getter, conditionally included based on `showPartnerDashboard`.
app/components/partner/client-list/index.ts	Updated `partnerClientList` getter to use `slice()` instead of `toArray()`. Retained spelling errors in `totalParnterClientCount` and `hasNoParnterClient`.
app/components/partner/client-plan/component.js	Changed method from `find` to `findRecord` in `getClientPlan` task for fetching client plans.
app/components/partner/client-project-list/index.ts	Updated `partnerClientProjectList` getter to use `slice()` instead of `toArray()`.
app/components/partner/client-report-download/index.js	Modified `getReports` task to access the first report using `this.reports[0].id` instead of `this.reports.firstObject.id`. Enhanced error handling in `downloadPDFReport`.
app/components/partner/client-uploads-list/index.ts	Updated `partnerClientUploadList` getter to use `slice()` instead of `toArray()`.
app/components/partner/credit-transfer/index.js	Changed method from `find` to `findRecord` in `fetchClientPlan` task for fetching client plans.
app/components/partner/invitation-list/index.ts	Updated `partnerRegistrationRequestList` getter to use `slice()` instead of `toArray()`. Retained spelling error in `partnerRegistrationRequestReponse`.
app/components/partner/registration-request-pending-list/index.ts	Updated `partnerRegistrationRequestList` getter to use `slice()` instead of `toArray()`. Enhanced error handling in `fetchPartnerRegistrationRequest`.
app/components/partner/registration-request-rejected-list/index.ts	Updated `partnerRegistrationRequestList` getter to use `slice()` instead of `toArray()`. Enhanced error handling in `fetchPartnerRegistrationRequest`.

Possibly related PRs

#1486: The changes in the OrganizationInvitationListComponent involve modifying the way lists are generated by switching from toArray() to slice(), aligning with the changes made in the main PR.
#1476: The FileListComponent and ProjectSettingsAnalysisSettingsVulnerabilityListComponent both updated their data retrieval methods from toArray() to slice(), mirroring the approach taken in the main PR.
#1481: The personalTokenList getter in the AccountSettingsDeveloperSettingsPersonaltokenListComponent also switched from toArray() to slice(), indicating a consistent approach to handling list data.
#1483: The AppMonitoringTableComponent updates the monitoringData getter to use slice() instead of toArray(), reflecting the same pattern of modifying data retrieval methods.
#1480: The sbomProjectList getter in the SbomAppListComponent changed from toArray() to slice(), paralleling the approach taken in the main PR regarding list management.

Suggested reviewers

Praseetha-KR
cosmosgenius
Yibaebi

Poem

🐰 In the garden where changes bloom,
New paths for partners find room.
With lists that now slice, oh what a delight,
Navigating through day and night.
Error messages clearer, like stars that shine bright,
Hopping along, everything feels right! 🌼

📜 Recent review details

**Configuration used: CodeRabbit UI** **Review profile: CHILL**

📥 Commits

Reviewing files that changed from the base of the PR and between 7c725cc9d03ef88c1467611fad2a89a8f559f3eb and e3ab621ad246b1d9c710d49a99dcf8ab65f5c2f2.

📒 Files selected for processing (10)

* `app/components/home-page/organization-dashboard/side-nav/index.ts` (1 hunks) * `app/components/partner/client-list/index.ts` (1 hunks) * `app/components/partner/client-plan/component.js` (1 hunks) * `app/components/partner/client-project-list/index.ts` (1 hunks) * `app/components/partner/client-report-download/index.js` (1 hunks) * `app/components/partner/client-uploads-list/index.ts` (1 hunks) * `app/components/partner/credit-transfer/index.js` (1 hunks) * `app/components/partner/invitation-list/index.ts` (2 hunks) * `app/components/partner/registration-request-pending-list/index.ts` (2 hunks) * `app/components/partner/registration-request-rejected-list/index.ts` (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (10)

* app/components/home-page/organization-dashboard/side-nav/index.ts * app/components/partner/client-list/index.ts * app/components/partner/client-plan/component.js * app/components/partner/client-project-list/index.ts * app/components/partner/client-report-download/index.js * app/components/partner/client-uploads-list/index.ts * app/components/partner/credit-transfer/index.js * app/components/partner/invitation-list/index.ts * app/components/partner/registration-request-pending-list/index.ts * app/components/partner/registration-request-rejected-list/index.ts

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

cloudflare-workers-and-pages[bot] commented 2 weeks ago

Deploying irenestaging with Cloudflare Pages

Latest commit:	`e3ab621`
Status:	✅ Deploy successful!
Preview URL:	https://cd59edb0.irenestaging.pages.dev
Branch Preview URL:	https://pd-1561-ember-5-upgrade-fix.irenestaging.pages.dev

View logs

cypress[bot] commented 2 weeks ago

Irene Run #523

Run Properties: Passed #523 • 7b94946750 ℹ️: Merge 791b773371cb725122e57d0fd5d3a6d15171fcc2 into 56fda9e7396dac44525bd93066b6...

Project	`Irene`
Branch Review	`PD-1561-ember-5-upgrade-fix-deprecation-in-partner-routes`
Run status	`Passed #523`
Run duration	`05m 04s`
Commit	`7b94946750 ℹ️: Merge 791b773371cb725122e57d0fd5d3a6d15171fcc2 into 56fda9e7396dac44525bd93066b6...`
Committer	`Avi Shah`
View all properties for this run ↗︎