applait / finderjs

Finder and file picker library for Firefox OS
http://finder.js.org
MIT License
14 stars 7 forks source link

Fixes #9 Write tests for matchname method #9 #11

Closed kumarrishav closed 9 years ago

kaustavdm commented 9 years ago

@kumarrishav You need to instantiate multiple times. As of now there is no setAttribute in FinderJS. This means, you cannot set property values after instantiation in the right context.

So, for each test, you need to instantiate with multiple configuration options. Check the README.md.

What you need to do is something like this instead:

var finder = Applait.Finder({ hidden: true })
kumarrishav commented 9 years ago

@kaustavdm what is the issue with this PR. It's working fine. I am able to instantiate like this Hidden: true. Searchkey: "&&&" Instead of this var finder = Applait.Finder({ hidden: true })

And it seems fine..

kumarrishav commented 9 years ago

@kaustavdm here i set only those property value which is needed for this function/test.

kaustavdm commented 9 years ago

@kumarrishav Please fix indentation to four spaces. Also, you need to pull in latest master into this.

kumarrishav commented 9 years ago

@kaustavdm Hope this is fine now. i followed jai's merged patch for Spaces/identation/new line rule's. I think for the sake of contributors, there is need to add details (like design css/identation rules, what testing framework we are using..etc) to README.md .

kaustavdm commented 9 years ago

@kumarrishav We did not expect to expect superb contributions like you at such an early stage. I will make sure to put in a CONTRIBUTORS.md document in the repo. I will also add a Sublime project file and a .dir-locals.el file for Emacs.Till then, just follow this please:

kaustavdm commented 9 years ago

@kumarrishav You, Sir, are one great fellow! :+1: Here, take this chocolate bar -> :chocolate_bar:

kumarrishav commented 9 years ago

@kaustavdm thank you ;) for chocolate :)