search

applait / finderjs

Finder and file picker library for Firefox OS
http://finder.js.org
MIT License
14 stars 7 forks source link

Fixes - #10 Write tests for log method #10 #12

Closed kumarrishav closed 9 years ago

kaustavdm commented 9 years ago

@kumarrishav This has an accidental extra commit outside the issue's scope. Plus, refer to https://github.com/applait/finderjs/pull/11#issuecomment-65962703. This needs some rework.

kaustavdm commented 9 years ago

@kumarrishav The diff is still messed up. Pull the latest master and apply your patch carefully on it.

Plus, instantiate with debugMode: true and debugMode: false in both the cases. Don't change this.debugmode on the fly.

kaustavdm commented 9 years ago

@kumarrishav Ignore the previous comment please. Go ahead with using this.debugmode = true or this.debugmode = false on the fly.

But you should check your text editor configs. You are introducing a lot of stale white spaces and breaking indentation because you have tabs and spaces mixed. Scary.

kaustavdm commented 9 years ago

@kumarrishav Impressive! Thanks a lot!