apple / app-store-server-library-python

MIT License
146 stars 31 forks source link

Fix nonce type annotation in PromotionalOfferSignatureCreator #17

Closed WFT closed 1 year ago

WFT commented 1 year ago

The old annotation for nonce was uuid the module, not uuid.UUID the actual UUID type in Python.

This will help with type checking once that works (see #15) and fixes the rendering of the docs. Those docs used to render like so:

create_signature(product_identifier: str, subscription_offer_id: str, application_username: str, nonce: <module 'uuid' from '/home/docs/.asdf/installs/python/3.11.4/lib/python3.11/uuid.py'>, timestamp: int)

and should now render like so:

create_signature(product_identifier: str, subscription_offer_id: str, application_username: str, nonce: uuid.UUID, timestamp: int)