feat: pydantic models - Githubissues

apple / app-store-server-library-python

MIT License

168 stars 31 forks source link

feat: pydantic models #35

Open ahnsv opened 1 year ago

ahnsv commented 1 year ago

Resolve #10

Hi, The test code gets messy to make the models (attr, pydantic) compatible. If it feels right, I want to merge them first, refactor them and apply more validation criteria on model fields in later PRs.

alexanderjordanbaker commented 1 year ago

@ahnsv A few high level questions:

Is your goal to have support for attr and pydantic both going forwards?
Is the V1 vs V2 model approach meant to be temporary or permanent?

ahnsv commented 1 year ago

@alexanderjordanbaker I think it would be better if we can replace it. In this PR, I added v2 for compatibility. Do you think that I should make it replace it in this PR?