search

apple / app-store-server-library-python

MIT License
168 stars 31 forks source link

Models: Fix typing issue for optional fields. #6

Closed tbenhamou closed 1 year ago

tbenhamou commented 1 year ago

In case an attribute has a default value of None, the typing hint should specify it's optional.

BTW, why to use attrs and not the native dataclasses module of Python? It's a way more simple...

alexanderjordanbaker commented 1 year ago

@tbenhamou Thank you for opening this pull request. Could you please confirm this PR follows our licensing guidelines as in https://github.com/apple/app-store-server-library-python/blob/main/CONTRIBUTING.md#project-licensing

tbenhamou commented 1 year ago

@tbenhamou Thank you for opening this pull request. Could you please confirm this PR follows our licensing guidelines as in main/CONTRIBUTING.md#project-licensing

It does :)